Skip to content

@W-22334153 Adding fixes for navigate action in Omniscript#493

Merged
sf-pallavi-das merged 2 commits into
salesforcecli:developfrom
sf-pallavi-das:u/pallavi-das/W-22334153_navigate_action
May 29, 2026
Merged

@W-22334153 Adding fixes for navigate action in Omniscript#493
sf-pallavi-das merged 2 commits into
salesforcecli:developfrom
sf-pallavi-das:u/pallavi-das/W-22334153_navigate_action

Conversation

@sf-pallavi-das
Copy link
Copy Markdown
Collaborator

@sf-pallavi-das sf-pallavi-das commented May 22, 2026 •
edited
Loading

What does this PR do?

  • Added processNavigateAction handler in that resolves Type/Sub Type/Language from the legacy LWC OmniScript reference using the name registry and clears the LWC name field.
  • Rewrites OmniScript Prefill keys from the managed-package c__ namespace to the standard runtime omniscript__ namespace (only at key boundaries, not inside values).
  • Wired the new Navigate Action constant into the dispatcher and added 6 unit tests in covering match/no-match, prefill rewriting, and dispatcher integration.

What issues does this PR fix or reference?

@sf-pallavi-das sf-pallavi-das requested a review from a team as a code owner May 22, 2026 15:39
shaurabh-tiwari-git
shaurabh-tiwari-git approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown

@shaurabh-tiwari-git shaurabh-tiwari-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdmehran-qureshi
mdmehran-qureshi approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mdmehran-qureshi mdmehran-qureshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

mdmehran-qureshi
mdmehran-qureshi reviewed May 25, 2026
View reviewed changes
Comment thread src/migration/omniscript.ts
Comment thread src/migration/omniscript.ts
Comment thread src/migration/omniscript.ts
Comment thread test/migration/omniscript-content-processing.test.ts Outdated
sf-kishore-kurri
sf-kishore-kurri approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sf-kishore-kurri sf-kishore-kurri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the video recording of the working use case post migration, changes LGTM

@sf-pallavi-das sf-pallavi-das force-pushed the u/pallavi-das/W-22334153_navigate_action branch from fa95e77 to adc5b42 Compare May 29, 2026 12:50
@sf-pallavi-das sf-pallavi-das merged commit 1350439 into salesforcecli:develop May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmehran-qureshi mdmehran-qureshi mdmehran-qureshi approved these changes

+2 more reviewers

@shaurabh-tiwari-git shaurabh-tiwari-git shaurabh-tiwari-git approved these changes

@sf-kishore-kurri sf-kishore-kurri sf-kishore-kurri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sf-pallavi-das @mdmehran-qureshi @shaurabh-tiwari-git @sf-kishore-kurri