@W-20048799 - Identification of action keyword during assessment#496
Conversation
| // "action" is a reserved keyword in the core runtime; flag any Custom LWC | ||
| // that defines it as a property so the user removes/renames it pre-migration. | ||
| if (Object.prototype.hasOwnProperty.call(component.property, 'action')) { | ||
| const lwcLabel = component.property.customlwcname || component.elementLabel || Constants.CustomLwc; |
There was a problem hiding this comment.
@shaurabh-tiwari-git As discussed over call, connect with Swati CX and add all the reserve keywords check with Flexcard custom attributes
There was a problem hiding this comment.
I've tried with other reserved keywords but they are not causing any issue in our case. They might be reserved for other places in the Flexcard but for our case only action keyword is failing in core runtime. Also, the PR by Adam in core for this issue (https://gitcore.soma.salesforce.com/core-2206/core-264-public/pull/2750) only addresses the "action" keyword.
| "cardNameChangeMessage": "The Flexcard name will be changed from %s to %s to adhere to the API naming standards.", | ||
| "authordNameChangeMessage": "The Flexcard author name will be changed from %s to %s to adhere to the naming rules", | ||
| "cardLWCNameChangeMessage": "The Flexcard generated LWC name will be changed from %s to %s to align with Flexcard name change.", | ||
| "customLwcReservedActionKey": "Custom LWC \"%s\" defines a reserved property key \"action\" which is not supported by the core runtime. Manual intervention required to remove or rename this key before migration.", |
There was a problem hiding this comment.
Message is not correct - remove is not an option which will impact the functionality so it should be renamed not using reserve keywords which will be shared as documentation link
| 'https://help.salesforce.com/s/articleView?id=xcloud.os_migrate_oma_prereq.htm&type=5', | ||
| corruptedParentChildLevel: 'https://help.salesforce.com/s/articleView?id=xcloud.os_version_omniscripts.htm&type=5', | ||
| customLwcReservedActionKey: | ||
| 'https://help.salesforce.com/s/articleView?id=xcloud.os_embed_a_custom_lwc_inside_a_flexcard.htm&type=5', |
There was a problem hiding this comment.
replace the link with CX created link which has clear steps on what should be done with this manual step
4 participants
What does this PR do?
What issues does this PR fix or reference?