small fixes#33
Open
soniah wants to merge 6 commits into
Open
Conversation
…versions to be locked
If both user/password are empty, shouldn't put "password: null" in api.json file. This is a quick HACK to get things working, a proper fix will be required.
gravyboat
reviewed
Nov 23, 2016
gravyboat
left a comment
gravyboat
left a comment
There was a problem hiding this comment.
I added a couple review notes. We should probably discuss the other changes as they seem to make this formula backwards incompatible.
| - dataset: | ||
| api: | ||
| host: {{ sensu.api.host }} | ||
| password: {{ sensu.api.password }} |
There was a problem hiding this comment.
Should we leave this in for backwards compatibility? and do some logic to handle when it should or should not be included?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes that I found while using the formula.