fix(minion): run own job when target id equals a managed resource id

[n0liu]

What does this PR do?

Fixes #69867.

When a minion's own id is also one of its managed resource ids, a bare (wildcard-free) glob target equal to that id is misclassified as a pure resource target. _target_load then sets minion_is_target to False, so the minion dispatches the job to the matching resource but skips running it on itself.

The offending branch in Minion._is_pure_resource_target matches any bare glob against every managed resource id without excluding the minion's own id:

if (
    tgt_type == "glob"
    and isinstance(tgt, str)
    and not any(c in tgt for c in ("*", "?", "[")):
):
    resources = self.opts.get("resources", {})
    for rids in resources.values():
        if tgt in rids:
            return True

How does this PR fix it?

Exclude the minion's own id from that bare-id match:

    and tgt != self.opts.get("id")

A target equal to the minion's own id is therefore no longer "pure resource", so minion_is_target stays True and the minion runs the job locally in addition to dispatching it to the resource. A bare id that is only a resource id (not the minion's own) is unaffected.

Tests

Added test_pure_resource_target_excludes_own_minion_id in tests/pytests/unit/test_minion_resources.py. It builds a minion whose id (dummy-01) is also a managed resource id and asserts:

• _is_pure_resource_target is False for the own-id target (fails before this change, passes after),
• and still True for a different resource id (dummy-02), guarding against over-correction.

python -m pytest tests/pytests/unit/test_minion_resources.py — 62 passed locally.

[twangboy]

Looks good. We fix bugs on the earliest branch where the bug exists. Resources were added in 3008. Please rebase this on the the 3008.x branch.

[n0liu]

Thanks for the review, @twangboy! Done — I've rebased this onto 3008.x and retargeted the PR base to that branch.

I re-verified the fix on 3008.x: _is_pure_resource_target's bare-id glob branch is present there and still exhibits the bug (returns True for the minion's own id when it collides with a managed resource id). With the fix, tests/pytests/unit/test_minion_resources.py passes (62 passed); removing the one-line guard makes test_pure_resource_target_excludes_own_minion_id fail as expected.