Skip to content

Several fixes for x509_v2 - #69894

Open
lkubb wants to merge 10 commits into
saltstack:3006.xfrom
lkubb:fix-509v2
Open

Several fixes for x509_v2#69894
lkubb wants to merge 10 commits into
saltstack:3006.xfrom
lkubb:fix-509v2

Conversation

@lkubb

@lkubb lkubb commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Ensures x509_v2 accounts for PKCS#7 being unordered.
  • Does not delete symlinks in test mode
  • Adds limited support for otherName definitions, which currently raise an exception when passed
  • Several minor fixes

What issues does this PR fix or reference?

Fixes: #69893
Fixes: #69895
Fixes: #69896
Fixes: #69898
Fixes: #69900

Previous Behavior

  • salt.utils.x509.load_cert could accidentally load a certificate that should be part of the chain as the leaf when it was encoded using PKCS#7
  • In these cases, x509.certificate_managed reported changes and reissued the certificate needlessly
  • An existing symlink at name was deleted by x509.certificate_managed and friends in test mode when follow_symlinks: false was passed
  • otherName definitions resulted in an error - a breaking change versus the previous x509 modules

New Behavior

  • Correct leaf and ordered chain are returned
  • No spurious changes
  • No deleted symlinks in test mode
  • Limited support for otherName

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant