Several fixes for x509_v2 - #69894
Open
lkubb wants to merge 10 commits into
Open
Conversation
x509_v2x509_v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
x509_v2accounts for PKCS#7 being unordered.otherNamedefinitions, which currently raise an exception when passedWhat issues does this PR fix or reference?
Fixes: #69893
Fixes: #69895
Fixes: #69896
Fixes: #69898
Fixes: #69900
Previous Behavior
salt.utils.x509.load_certcould accidentally load a certificate that should be part of the chain as the leaf when it was encoded using PKCS#7x509.certificate_managedreported changes and reissued the certificate needlesslynamewas deleted byx509.certificate_managedand friends in test mode whenfollow_symlinks: falsewas passedotherNamedefinitions resulted in an error - a breaking change versus the previousx509modulesNew Behavior
otherNameMerge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes