Added two pages angular defer loading and control flow in angular by pawanpatil08 · Pull Request #48 · santoshyadavdev/angular-snippets

pawanpatil08 · 2023-07-22T13:52:06Z

No description provided.

netlify · 2023-07-22T13:52:11Z

❌ Deploy Preview for charming-faun-72b6b3 failed.

Name	Link
🔨 Latest commit	`2c611f7`
🔍 Latest deploy log	https://app.netlify.com/sites/charming-faun-72b6b3/deploys/64c880375e3a4e00071e023f

santoshyadavdev · 2023-07-24T22:01:11Z

Thank you @pawanpatil08 I will review this, I need to check why build is failed

ajitzero · 2023-07-31T21:10:37Z

+      "avatar_url": "https://avatars.githubusercontent.com/u/16464034?v=4",
+      "profile": "https://github.com/pawanpatil08",
+      "contributions": [
+        "code"


Suggested change

"code"

"doc"

Snippet submissions fall under the "doc" category of contributions.

any specific reason for this

Done @ajitzero

"code" is for project logic changes, e.g., adding a feature like a theme toggle, fixing bugs like rendering issues, etc.

A snippet/article is a documentation change.

Here's the full table of keywords with description: https://allcontributors.org/docs/en/emoji-key

The best fit is the "content" category, but it isn't used as much, so everything unrelated to code falls under "docs".

ajitzero · 2023-07-31T21:12:10Z

      <td align="center" valign="top" width="14.28%"><a href="https://github.com/deepakrudrapaul"><img src="https://avatars.githubusercontent.com/u/25549935?v=4?s=100" width="100px;" alt="Deepak Rudra Paul"/><br /><sub><b>Deepak Rudra Paul</b></sub></a><br /><a href="https://github.com/santoshyadavdev/angular-snippets/commits?author=deepakrudrapaul" title="Documentation">📖</a></td>
      <td align="center" valign="top" width="14.28%"><a href="https://github.com/rubenperegrina"><img src="https://avatars.githubusercontent.com/u/23550574?v=4?s=100" width="100px;" alt="Rubén Peregrina"/><br /><sub><b>Rubén Peregrina</b></sub></a><br /><a href="https://github.com/santoshyadavdev/angular-snippets/commits?author=rubenperegrina" title="Documentation">📖</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://github.com/pawanpatil08"><img src="https://avatars.githubusercontent.com/u/16464034?v=4?s=100" width="100px;" alt="Pawan Patil"/><br /><sub><b>Pawan Patil</b></sub></a><br /><a href="https://github.com/santoshyadavdev/angular-snippets/commits?author=pawanpatil08" title="Code">💻</a></td>
+


This part should be auto-generated from .all-contributorsrc, so this shouldn't be manually committed.

ajitzero · 2023-07-31T21:12:35Z

@@ -0,0 +1,83 @@
+---
+title: Build in control flow upcoming Angular


Suggested change

title: Build in control flow upcoming Angular

title: Built-in control flow in upcoming Angular

Typo

ajitzero · 2023-07-31T21:14:27Z

+{/if}
+```
+
+link for RFC : https://github.com/angular/angular/discussions/50719


As you've rightly pointed out here, this is still an RFC and is open to change. I think we should hold off on this until it's confirmed and out in Angular 17 (probably)

Correct that why added the upcoming in angular

ajitzero · 2023-07-31T21:16:08Z

@@ -0,0 +1,64 @@
+---


Same point here. Please push this off until the RFC is closed, and we actually have an initial implementation.

@santoshyadavdev Can you Suggest here,

ajitzero · 2023-07-31T21:17:47Z

+contributedBy: "@pawanpatil08"
+---
+
+as a part of our ongoing work on implementing the Signals RFC,


I see a lot of minor grammar issues / non-capital letters. Please run this through Grammarly or Google Docs since your actual content is well-written but has many obvious issues which can be fixed automatically.

Hey, @ajitzero tried it in Google Docs.
please suggest the any mistake in this file

pawanpatil08

Hi, @santoshyadavdev ,
Can you please review the changes and let me know about Ajit's suggestion?

pawanpatil08 · 2023-08-01T03:47:28Z

+      "avatar_url": "https://avatars.githubusercontent.com/u/16464034?v=4",
+      "profile": "https://github.com/pawanpatil08",
+      "contributions": [
+        "code"


Done @ajitzero

pawanpatil08 · 2023-08-01T03:49:55Z

+contributedBy: "@pawanpatil08"
+---
+
+as a part of our ongoing work on implementing the Signals RFC,


Hey, @ajitzero tried it in Google Docs.
please suggest the any mistake in this file

pawanpatil08 · 2023-08-01T03:50:39Z

@@ -0,0 +1,64 @@
+---


@santoshyadavdev Can you Suggest here,

ajitzero · 2023-08-01T08:52:01Z

@@ -1,7 +1,9 @@
 # Angular Snippets

 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->


Please remove this file from the PR since the comment explicitly asks to have no changes. These whitespace are probably fine but pointless to add them.

ajitzero · 2023-08-01T08:52:29Z

@@ -0,0 +1,83 @@
+---
+title: Built-in control flow in upcoming Angular
+description: "Build in control"


Suggested change

description: "Build in control"

description: "Built-in control"

ajitzero · 2023-08-01T08:53:01Z

+- Syntactically distinct from HTML syntax.
+- Works across multiple templates (if-elseif-else, switch-case-default), including template type-checking.
+- Flexible syntax allowing customization for each use case (if vs for vs switch).
+  Address common pain points.


Suggested change

Address common pain points.

- Address common pain points.

ajitzero · 2023-08-01T08:55:08Z

+  {:case x}
+    X case
+  {:case y}
+    Y case


This syntax is not finalized in the RFC since, in the replies, it has been pointed out that they may support multiple cases in one line: {:case x, y}

This is part of the reason I suggest keep this snippet as a draft until the features are actually out.

ajitzero · 2023-08-01T08:55:30Z

+{/if}
+```
+
+### if block - conditionals


Suggested change

### if block - conditionals

### if block - Conditionals

ajitzero · 2023-08-01T08:56:15Z

+contributedBy: "@pawanpatil08"
+---
+
+as a part of our ongoing work on implementing the Signals RFC,


Suggested change

as a part of our ongoing work on implementing the Signals RFC,

As a part of our ongoing work on implementing the Signals RFC,

ajitzero · 2023-08-01T08:56:33Z

+---
+
+as a part of our ongoing work on implementing the Signals RFC,
+we’ve known that the existing zone-based control flow directives would not be able to function in zoneless applications.


Suggested change

we’ve known that the existing zone-based control flow directives would not be able to function in zoneless applications.

We've known that the existing zone-based control flow directives would not be able to function in zoneless applications.

ajitzero · 2023-08-01T08:58:31Z

+as a part of our ongoing work on implementing the Signals RFC,
+we’ve known that the existing zone-based control flow directives would not be able to function in zoneless applications.
+We will need to implement reactive control flow for zoneless applications.
+We considered modifying the existing control flow directives to support zoneless applications as well,


Suggested change

We considered modifying the existing control flow directives to support zoneless applications as well,

We considered modifying the existing control flow directives to support zoneless applications as well.

This entire paragraph is copied from different parts of the RFC. Please rewrite is slightly so the next line makes sense from the previous line. Again, Grammarly should be sufficient.

ajitzero · 2023-08-01T08:59:25Z

+
+- Make deferred loading in Angular predictable and ergonomic for all developers
+- Reduce initial page load time due to smaller initial bundle sizes
+  8 Support deferred loading of directives & pipes as well as components


Suggested change

8 Support deferred loading of directives & pipes as well as components

- Support deferred loading of directives & pipes as well as components

I am not sure about this, since "8" looks like a typo but the rest of the sentences don't seem to be related.

ajitzero · 2023-08-01T09:01:33Z

+{/defer}
+```
+
+Will see you Built-In Control Flow in next snippets


Suggested change

Will see you Built-In Control Flow in next snippets

This line makes no sense.

santoshyadavdev · 2023-08-05T21:52:09Z

Thank you both I am trying to figure out the build issue, I will soon review the PR

santoshyadavdev · 2023-08-19T21:40:54Z

ing the Signals RFC,

Hi @pawanpatil08 thank you for PR. Let me know once you take care of comments from @ajitzero, also if you can update the branch from main that would be greatt.

pawanpatil08 added 2 commits July 22, 2023 19:18

added two pages for angular signal and defer loading

91ad10a

removed last line

bb01a25

Aded the rfc link

e4bd0c5

ajitzero reviewed Jul 31, 2023

View reviewed changes

pawanpatil08 added 2 commits August 1, 2023 09:06

PR review Changes

ee45539

adding the all cont. change

2c611f7

pawanpatil08 commented Aug 1, 2023

View reviewed changes

ajitzero suggested changes Aug 1, 2023

View reviewed changes

		@@ -0,0 +1,83 @@
		---
		title: Build in control flow upcoming Angular

	title: Build in control flow upcoming Angular
	title: Built-in control flow in upcoming Angular

		@@ -1,7 +1,9 @@
		# Angular Snippets

		<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->

	description: "Build in control"
	description: "Built-in control"

	as a part of our ongoing work on implementing the Signals RFC,
	As a part of our ongoing work on implementing the Signals RFC,

	we’ve known that the existing zone-based control flow directives would not be able to function in zoneless applications.
	We've known that the existing zone-based control flow directives would not be able to function in zoneless applications.

	We considered modifying the existing control flow directives to support zoneless applications as well,
	We considered modifying the existing control flow directives to support zoneless applications as well.

	8 Support deferred loading of directives & pipes as well as components
	- Support deferred loading of directives & pipes as well as components

Uh oh!

Conversation

pawanpatil08 commented Jul 22, 2023

Uh oh!

netlify Bot commented Jul 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for charming-faun-72b6b3 failed.

Uh oh!

santoshyadavdev commented Jul 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajitzero Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawanpatil08 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

santoshyadavdev commented Aug 5, 2023

Uh oh!

santoshyadavdev commented Aug 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Jul 22, 2023 •

edited

Loading

ajitzero Jul 31, 2023 •

edited

Loading

pawanpatil08 left a comment •

edited

Loading