Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/multi-c2d8b9b5ce
branch
from
cc7d1fe to
d5f6027
Compare
|
@dependabot recreate |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/multi-c2d8b9b5ce
branch
from
d5f6027 to
78a9687
Compare
|
@dependabot rebase |
|
@dependabot recreate |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/multi-c2d8b9b5ce
branch
from
78a9687 to
19b4be1
Compare
Bumps [eslint](https://github.com/eslint/eslint) to 9.39.2 and updates ancestor dependency [gts](https://github.com/google/gts). These dependencies need to be updated together. Updates `eslint` from 7.32.0 to 9.39.2 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v7.32.0...v9.39.2) Updates `gts` from 3.1.1 to 7.0.0 - [Release notes](https://github.com/google/gts/releases) - [Changelog](https://github.com/google/gts/blob/main/CHANGELOG.md) - [Commits](https://github.com/google/gts/commits/v7.0.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.39.2 dependency-type: indirect - dependency-name: gts dependency-version: 7.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Goodwine
force-pushed
the
dependabot/npm_and_yarn/multi-c2d8b9b5ce
branch
from
19b4be1 to
c9bcb0b
Compare
- this required upgrading the eslint config - lint fixes applied - applied lint on additional files that should have been linted but were not, oops
- add void to top level promises - change arrow functions with names to function declarations - add explicit return types - add missing awaits in test - return 'sandbox()' promises
|
upgrading gts (which upgrades eslint) brought out issues in the existing setup, including non-awaited promises which highlighted one bug in a test, but for some reason another test is failing... I think the "lock" on the channel is being released too early, and I wasn't able to figure it out last week. I might try again this week :) |
- apparenlty we can't add files that declare jasmine matchers in tsconfig if `jest` is involved because then types conflict - fixes custom expectation tester test (meta test?) returning a value other than expected (surfaced by awaiting on promises)
- use async interactor as shown in the nopdejs docs
|
looking at https://nodejs.org/api/readline.html, I think it's necessary to use a shared |
|
I tried using the |
|
Tested interactor manually too with I injected a few failures and validated that sending a wave of O lines fixed the tests without freezing. I did not understand well the approach with |
|
@nex3 PTAL The main changes are:
The rest of the changes are:
|
2 participants
Bumps eslint to 9.39.2 and updates ancestor dependency gts. These dependencies need to be updated together.
Updates
eslintfrom 7.32.0 to 9.39.2Release notes
Sourced from eslint's releases.
... (truncated)
Commits
92783249.39.2542266aBuild: changelog update for 9.39.27ca0af7chore: upgrade to@eslint/js@9.39.2(#20394)c43ce24chore: package.json update for@eslint/jsrelease5705833fix: warn wheneslint-envconfiguration comments are found (#20381)506f154build: add .scss files entry to knip (#20391)4c9858eci: addv9.x-devbranch (#20382)e2772819.39.14cdf397Build: changelog update for 9.39.192db329chore: update@eslint/jsversion to 9.39.1 (#20284)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Updates
gtsfrom 3.1.1 to 7.0.0Release notes
Sourced from gts's releases.
... (truncated)
Changelog
Sourced from gts's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.