Bump starlette from 0.41.2 to 1.3.1 in /experiments/agentcompany/openhands#37
Conversation
Bumps [starlette](https://github.com/Kludex/starlette) from 0.41.2 to 1.3.1. - [Release notes](https://github.com/Kludex/starlette/releases) - [Changelog](https://github.com/Kludex/starlette/blob/main/docs/release-notes.md) - [Commits](Kludex/starlette@0.41.2...1.3.1) --- updated-dependencies: - dependency-name: starlette dependency-version: 1.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| soupsieve==2.5 | ||
| stack-data==0.6.3 | ||
| starlette==0.41.2 | ||
| starlette==1.3.1 |
There was a problem hiding this comment.
fastapi==0.115.4 in this same requirements file requires starlette>=0.40.0,<0.42.0, but this change pins starlette==1.3.1. With both pins present, pip cannot resolve the environment, so installing experiments/agentcompany/openhands/requirements.txt fails before the OpenHands experiment can run. If Starlette is forced past the resolver, FastAPI is still running against an unsupported major version of its Starlette dependency. Please either keep Starlette inside FastAPI 0.115.4's supported range or bump FastAPI to a release that supports Starlette 1.x.
Artifacts
PyPI metadata check showing fastapi 0.115.4 requires starlette<0.42.0
- Keeps the command output available without making the summary code-heavy.
PyPI metadata check showing fastapi 0.115.4 requires starlette<0.42.0
- Keeps the command output available without making the summary code-heavy.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: experiments/agentcompany/openhands/requirements.txt
Line: 169
Comment:
**FastAPI constraint conflict**
`fastapi==0.115.4` in this same requirements file requires `starlette>=0.40.0,<0.42.0`, but this change pins `starlette==1.3.1`. With both pins present, pip cannot resolve the environment, so installing `experiments/agentcompany/openhands/requirements.txt` fails before the OpenHands experiment can run. If Starlette is forced past the resolver, FastAPI is still running against an unsupported major version of its Starlette dependency. Please either keep Starlette inside FastAPI 0.115.4's supported range or bump FastAPI to a release that supports Starlette 1.x.
How can I resolve this? If you propose a fix, please make it concise.
Bumps starlette from 0.41.2 to 1.3.1.
Release notes
Sourced from starlette's releases.
... (truncated)
Changelog
Sourced from starlette's changelog.
... (truncated)
Commits
8ebffd0Version 1.3.1 (#3330)25b8e17EnforceFormParserlimits in parser callbacks (#3331)dba1c4bEnforcemax_fieldsandmax_part_sizeinFormParser(#3329)45e51dcUseStarletteDeprecationWarninginstead ofDeprecationWarning(#3119)5f8610cVersion 1.3.0 (#3327)167b585Buildrequest.urlfrom structured components (#3326)3730925Useremoveprefixto strip weak ETag indicator inis_not_modified(#3193)e6f7ad1avoid collapsing exception groups from user code (#2830)115228fAnnotate URLPath protocol parameter with Literal (#3285)113f193docs: replace inline ASGI server list with link to canonical implemen… (#3204)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Greptile Summary
This PR updates the OpenHands experiment's Python dependency pin for Starlette. It changes:
starlettefrom0.41.2to1.3.1.experiments/agentcompany/openhands/requirements.txt.Confidence Score: 1/5
Not safe to merge until T-Rex findings are addressed.
T-Rex reproduced 2 failing behaviors at runtime in experiments/agentcompany/openhands/requirements.txt; the change needs fixes before it is safe to merge.
experiments/agentcompany/openhands/requirements.txtneeds the Starlette/FastAPI pins aligned.What T-Rex did
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Bump starlette in /experiments/agentcomp..." | Re-trigger Greptile