monitoring: check dashboard build fine#2440
Conversation
| - name: Install dependencies | ||
| working-directory: monitoring | ||
| run: pip install -r requirements.txt | ||
| - name: Generate dashboards |
There was a problem hiding this comment.
Why do we re-generate them in the CI instead of just generating and not commiting them ?
There was a problem hiding this comment.
- It allows testing/deploying more easily : i.e. the pre-generated dashboard.json is already available for loading on a platform (manually, from grafana UI) if needed. For example for troubleshooting with CS team.
- the CI check verifies they are indeed correctly generated (i.e. proper dependencies, ...)
49576a4 to
007e471
Compare
- upgrade grafanalib to latest version - use requirements.txt to track these dependencies - re-generate in CI to verify the json is up to date with the py source - remove unused mongodb exporter metrics Issue: ZENKO-5099
007e471 to
cb46c35
Compare
|
/approve |
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
This pull request does not target the following hotfix branch(es) so they
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
Issue: ZENKO-5099