Skip to content

remove unused port-forward PID captures#2446

Open
delthas wants to merge 1 commit into
development/2.15from
improvement/ZENKO-5298/cleanup-pf-pid
Open

remove unused port-forward PID captures#2446
delthas wants to merge 1 commit into
development/2.15from
improvement/ZENKO-5298/cleanup-pf-pid

Conversation

@delthas

@delthas delthas commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Drop three _*_PF_PID=$! assignments in .github/scripts/end2end/setup-e2e-env.sh that are never read again — no wait, kill, or disown references the captured PIDs anywhere in the file.
  • Pure cleanup, no behavior change. kubectl port-forward ... & already detaches into the background fine without the capture.

Removed

  • _KAFKA_PF_PID
  • _KAFKA_AUTH_PF_PID
  • _PROM_PF_PID

Why

Flagged by @maeldonn on PR #2378 review for two new captures we'd added (_JAEGER_PF_PID, _CLOUDSERVER_INTERNAL_PF_PID); those were dropped in that PR. This one handles the three pre-existing ones.

Issue: ZENKO-5298

Three `_*_PF_PID=$!` assignments in setup-e2e-env.sh are never
referenced after they're set — no wait, kill, or disown. The
port-forwards already run in the background fine without capturing
the PID.

Removes `_KAFKA_PF_PID`, `_KAFKA_AUTH_PF_PID`, `_PROM_PF_PID`. Pure
cleanup, no behavior change.

Flagged by Maël on Zenko PR #2378 review.

Issue: ZENKO-5298
@bert-e

bert-e commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@SylvainSenechal SylvainSenechal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was a problem with it, or is it a pure 3 lines removal cleanup 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants