remove unused port-forward PID captures#2446
Open
delthas wants to merge 1 commit into
Open
Conversation
Three `_*_PF_PID=$!` assignments in setup-e2e-env.sh are never referenced after they're set — no wait, kill, or disown. The port-forwards already run in the background fine without capturing the PID. Removes `_KAFKA_PF_PID`, `_KAFKA_AUTH_PF_PID`, `_PROM_PF_PID`. Pure cleanup, no behavior change. Flagged by Maël on Zenko PR #2378 review. Issue: ZENKO-5298
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
SylvainSenechal
approved these changes
Jun 17, 2026
SylvainSenechal
left a comment
Contributor
There was a problem hiding this comment.
there was a problem with it, or is it a pure 3 lines removal cleanup 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_*_PF_PID=$!assignments in.github/scripts/end2end/setup-e2e-env.shthat are never read again — nowait,kill, ordisownreferences the captured PIDs anywhere in the file.kubectl port-forward ... &already detaches into the background fine without the capture.Removed
_KAFKA_PF_PID_KAFKA_AUTH_PF_PID_PROM_PF_PIDWhy
Flagged by @maeldonn on PR #2378 review for two new captures we'd added (
_JAEGER_PF_PID,_CLOUDSERVER_INTERNAL_PF_PID); those were dropped in that PR. This one handles the three pre-existing ones.Issue: ZENKO-5298