Skip to content

Send signatureVersion and authType unswapped to Vault checkPolicies - #6239

Open
benzekrimaha wants to merge 5 commits into
development/9.1from
improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
Open

Send signatureVersion and authType unswapped to Vault checkPolicies#6239
benzekrimaha wants to merge 5 commits into
development/9.1from
improvement/CLDSRV-963-fix-swapped-auth-params-check-policies

Conversation

@benzekrimaha

@benzekrimaha benzekrimaha commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

multiObjectDelete swapped signatureVersion and authType when building the checkPolicies request context sent to Vault, so each field was validated and evaluated against the other's value. Found while investigating RD-1890 (Veeam DeleteObjects failures).

Issue: CLDSRV-963

multiObjectDelete assigned authType to signatureVersion and vice versa
when building the checkPolicies request context, so Vault validated and
evaluated each field against the wrong value.

Issue: CLDSRV-963
@bert-e

bert-e commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-963 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.15

  • 9.2.42

  • 9.3.15

  • 9.4.0

Please check the Fix Version/s of CLDSRV-963, or the target
branch of this pull request.

@bert-e

bert-e commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-963 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.1.15

  • 9.2.42

  • 9.3.16

  • 9.4.0

Please check the Fix Version/s of CLDSRV-963, or the target
branch of this pull request.

@benzekrimaha benzekrimaha changed the title CLDSRV-963: Send signatureVersion and authType unswapped to Vault checkPolicies Send signatureVersion and authType unswapped to Vault checkPolicies Jul 31, 2026
@benzekrimaha
benzekrimaha requested review from a team, SylvainSenechal and delthas July 31, 2026 07:03
@bert-e

bert-e commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@benzekrimaha

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies with contents from improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
and development/9.2.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies origin/development/9.2
 git merge origin/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies

The following options are set: create_integration_branches

@benzekrimaha

Copy link
Copy Markdown
Contributor Author

Integration branch w/9.2 created manually with the conflict resolved (version bumped to 9.2.42).

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies with contents from w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies origin/development/9.3
 git merge origin/w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies

The following options are set: create_integration_branches

@benzekrimaha

Copy link
Copy Markdown
Contributor Author

Integration branch w/9.3 created with the conflict resolved (version bumped to 9.3.16).

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the creation of
integration branch w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies with contents from w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
and development/9.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies origin/development/9.4
 git merge origin/w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies

The following options are set: create_integration_branches

@benzekrimaha

Copy link
Copy Markdown
Contributor Author

Integration branch w/9.4 created with the conflict resolved (version bumped to 9.4.0-preview.7).

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@benzekrimaha

Copy link
Copy Markdown
Contributor Author

/create_pull_requests

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

History mismatch

Merge commit #21a5ae9515c392527f62171b0fc879038716f81f on the integration branch
w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies is merging a branch which is neither the current
branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies nor the development branch
development/9.4.

It is likely due to a rebase of the branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

History mismatch

Merge commit #39a5e96319a9a84100c04d190fd86af62dcd7d07 on the integration branch
w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies is merging a branch which is neither the current
branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies nor the development branch
development/9.4.

It is likely due to a rebase of the branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

History mismatch

Merge commit #3d83c119356101dccbbdea05430e9ba476fce84a on the integration branch
w/9.4/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies is merging a branch which is neither the current
branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies nor the development branch
development/9.4.

It is likely due to a rebase of the branch improvement/CLDSRV-963-fix-swapped-auth-params-check-policies and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

@bert-e

bert-e commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Conflict

A conflict has been raised during the update of
integration branch w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies with contents from w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
and development/9.3.

Please resolve the conflict on the integration branch (w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies).

Here are the steps to resolve this conflict:

 git fetch
 git checkout w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
 git pull  # or "git reset --hard origin/w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies"
 git merge origin/development/9.3
 # <intense conflict resolution>
 git commit
 git merge origin/w/9.2/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/improvement/CLDSRV-963-fix-swapped-auth-params-check-policies

The following options are set: create_pull_requests, create_integration_branches

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7696 1 7695 0
View the top 1 failed test(s) by shortest run time
"after each" hook for "should create new versions but still keep nullVersionId"::put and head object with versioning With v4 signature "after each" hook for "should create new versions but still keep nullVersionId"
Stack Traces | 0.091s run time
The bucket you tried to delete is not empty.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bert-e

bert-e commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_pull_requests, create_integration_branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants