Bugfix/s3 utils 239 fix count items bucket logging by benzekrimaha · Pull Request #394 · scality/s3utils

benzekrimaha · 2026-05-22T15:35:38Z

In the PR we are nullifying _bucketLoggingStatus which is safe for count-items specifically: that this metadata is unrelated to object count / storage usage computation and only exists on the BucketInfo object because it is part of the full bucket metadata model.
The implementation we now have is cleaner and makes this explicit by naming the fields as unsupported serialized BucketInfo fields for count-items.
The rationale being that : class-backed fields that count-items does not consume should not be rehydrated in the worker path just to count object metadata.

Issue: S3UTILS-239

bert-e · 2026-05-22T15:35:43Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2026-05-22T15:41:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.28%. Comparing base (86f5889) to head (9a5c496).

Additional details and impacted files

@@                 Coverage Diff                  @@
##           development/1.16     #394      +/-   ##
====================================================
+ Coverage             45.23%   45.28%   +0.04%     
====================================================
  Files                    85       85              
  Lines                  6046     6049       +3     
  Branches               1282     1283       +1     
====================================================
+ Hits                   2735     2739       +4     
+ Misses                 3265     3264       -1     
  Partials                 46       46

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SylvainSenechal · 2026-05-26T08:38:32Z

 const { deserializeBigInts, serializeBigInts } = require('./utils/utils');

 const PENSIEVE = 'PENSIEVE';
+const unsupportedSerializedBucketInfoFields = [


could have kept the comment about why we do this 🤔

maeldonn

Once normalizeBucketInfoForCountItems updated, it will be good for me !

francoisferrand

Current change introduces a performance impact, which is not worth as already pointed out (esp. considering count items is end of life!)

Issue: S3UTILS-239

francoisferrand

LGTM.

Do we need the fix on 1.16? I see zenko 2.14 and 2.15 both use s3utils 1.17, and not sure if the problem can be reproduced with zenko 2.13 (which uses cloudserver 9.1.14)

if not needed → rebase on 1.17
if needed → add a bump commit on waterflow branch & release both 1.16 and 1.17

bert-e · 2026-06-10T15:03:26Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

benzekrimaha · 2026-06-10T15:16:46Z

/create_integration_branches

bert-e · 2026-06-10T15:55:41Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

benzekrimaha · 2026-06-10T15:55:42Z

/create_pull_requests

bert-e · 2026-06-10T15:56:16Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/S3UTILS-239-fix-count-items-bucket-logging into
development/1.16
w/1.17/bugfix/S3UTILS-239-fix-count-items-bucket-logging will be merged into development/1.17 (pull request INTEGRATION [PR#394 > development/1.17] Bugfix/s3 utils 239 fix count items bucket logging #397)
w/1/bugfix/S3UTILS-239-fix-count-items-bucket-logging will be merged into development/1 (pull request INTEGRATION [PR#394 > development/1] Bugfix/s3 utils 239 fix count items bucket logging #398)

The following branches will NOT be impacted:

development/1.13
development/1.14
development/1.15
development/1.4
development/1.7

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests, create_integration_branches

bert-e · 2026-06-10T15:56:18Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests, create_integration_branches

benzekrimaha · 2026-06-10T15:56:43Z

/approve

bert-e · 2026-06-10T16:09:28Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/1.16
✔️ development/1.17
✔️ development/1

The following branches have NOT changed:

development/1.13
development/1.14
development/1.15
development/1.4
development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

hotfix/1.14.0

Please check the status of the associated issue S3UTILS-239.

Goodbye benzekrimaha.

The following options are set: approve, create_pull_requests, create_integration_branches

scality deleted a comment from bert-e May 22, 2026

benzekrimaha requested review from a team, SylvainSenechal and maeldonn May 22, 2026 15:40

SylvainSenechal approved these changes May 26, 2026

View reviewed changes

SylvainSenechal reviewed May 26, 2026

View reviewed changes

maeldonn approved these changes May 26, 2026

View reviewed changes

Comment thread CountItems/CountWorker.js Outdated

Comment thread CountItems/CountWorker.js Outdated

francoisferrand requested changes Jun 9, 2026

View reviewed changes

Comment thread CountItems/CountWorker.js Outdated

benzekrimaha force-pushed the bugfix/S3UTILS-239-fix-count-items-bucket-logging branch from ce5c1f7 to 37da7d2 Compare June 10, 2026 12:34

benzekrimaha added 3 commits June 10, 2026 14:36

Simplify count-items bucket metadata handling

8324d27

Issue: S3UTILS-239

Cover unsupported bucket metadata fields

e9465b0

Issue: S3UTILS-239

bump project version

9a5c496

Issue: S3UTILS-239

benzekrimaha force-pushed the bugfix/S3UTILS-239-fix-count-items-bucket-logging branch from 37da7d2 to 9a5c496 Compare June 10, 2026 12:36

benzekrimaha requested a review from francoisferrand June 10, 2026 12:36

francoisferrand approved these changes Jun 10, 2026

View reviewed changes

scality deleted a comment from bert-e Jun 10, 2026

bert-e mentioned this pull request Jun 10, 2026

INTEGRATION [PR#394 > development/1.17] Bugfix/s3 utils 239 fix count items bucket logging #397

Merged

bert-e mentioned this pull request Jun 10, 2026

INTEGRATION [PR#394 > development/1] Bugfix/s3 utils 239 fix count items bucket logging #398

Merged

bert-e merged commit 9a5c496 into development/1.16 Jun 10, 2026
12 checks passed

bert-e deleted the bugfix/S3UTILS-239-fix-count-items-bucket-logging branch June 10, 2026 16:09

Conversation

benzekrimaha commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented May 22, 2026

Hello benzekrimaha,

Uh oh!

codecov Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SylvainSenechal May 26, 2026

Choose a reason for hiding this comment

Uh oh!

maeldonn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

francoisferrand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francoisferrand left a comment

Choose a reason for hiding this comment

Uh oh!

bert-e commented Jun 10, 2026

Request integration branches

Uh oh!

benzekrimaha commented Jun 10, 2026

Uh oh!

bert-e commented Jun 10, 2026

Waiting for approval

Uh oh!

benzekrimaha commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Jun 10, 2026

Integration data created

Uh oh!

bert-e commented Jun 10, 2026

Waiting for approval

Uh oh!

benzekrimaha commented Jun 10, 2026

Uh oh!

bert-e commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

benzekrimaha commented May 22, 2026 •

edited

Loading

codecov Bot commented May 22, 2026 •

edited

Loading

benzekrimaha commented Jun 10, 2026 •

edited

Loading