Skip to content

S3UTILS-241: fix truncated metadata writes for multi-byte UTF-8 object keys#400

Merged
bert-e merged 2 commits into
development/1.17from
bugfix/S3UTILS-241-object-repair-writes-truncated-metadata
Jun 18, 2026
Merged

S3UTILS-241: fix truncated metadata writes for multi-byte UTF-8 object keys#400
bert-e merged 2 commits into
development/1.17from
bugfix/S3UTILS-241-object-repair-writes-truncated-metadata

Conversation

@jonathan-gramain

Copy link
Copy Markdown
Contributor

Summary

  • Fix content-length in httpRequest being set to string character count instead of byte length, causing truncated writes when the body contains multi-byte UTF-8 characters (e.g. object keys with non-ASCII characters)
  • Add unit tests for httpRequest (GET and POST with multi-byte UTF-8 body) and putObjectMetadata (success, malformed URL, non-200 response)

Test plan

  • yarn test:unit passes
  • Verify on a cluster that putObjectMetadata with non-ASCII object keys no longer produces truncated metadata in bucketd

🤖 Generated with Claude Code

jonathan-gramain and others added 2 commits June 17, 2026 11:28
…Request tests

Convert string request bodies to Buffer before sending so that
content-length reflects byte length rather than character count,
preventing truncated writes for bodies containing multi-byte UTF-8
characters.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bert-e

bert-e commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.92%. Comparing base (2db148e) to head (8813e3c).

Files with missing lines Patch % Lines
repairDuplicateVersionsSuite.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.17     #400      +/-   ##
====================================================
- Coverage             44.94%   44.92%   -0.03%     
====================================================
  Files                    88       88              
  Lines                  6459     6462       +3     
  Branches               1353     1354       +1     
====================================================
  Hits                   2903     2903              
- Misses                 3510     3513       +3     
  Partials                 46       46              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonathan-gramain jonathan-gramain force-pushed the bugfix/S3UTILS-241-object-repair-writes-truncated-metadata branch from 8813e3c to a16c506 Compare June 18, 2026 00:11
@jonathan-gramain

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@jonathan-gramain

Copy link
Copy Markdown
Contributor Author

I removed the version bump commit as I am planning on also implementing S3UTILS-242 as an improvement to object repair.

@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.17

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/1.14.0

Please check the status of the associated issue S3UTILS-241.

Goodbye jonathan-gramain.

The following options are set: approve

@bert-e bert-e merged commit a16c506 into development/1.17 Jun 18, 2026
13 of 15 checks passed
@bert-e bert-e deleted the bugfix/S3UTILS-241-object-repair-writes-truncated-metadata branch June 18, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants