S3UTILS-241: fix truncated metadata writes for multi-byte UTF-8 object keys#400
Conversation
…Request tests Convert string request bodies to Buffer before sending so that content-length reflects byte length rather than character count, preventing truncated writes for bodies containing multi-byte UTF-8 characters. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Hello jonathan-gramain,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/1.17 #400 +/- ##
====================================================
- Coverage 44.94% 44.92% -0.03%
====================================================
Files 88 88
Lines 6459 6462 +3
Branches 1353 1354 +1
====================================================
Hits 2903 2903
- Misses 3510 3513 +3
Partials 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8813e3c to
a16c506
Compare
|
/approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
|
I removed the version bump commit as I am planning on also implementing S3UTILS-242 as an improvement to object repair. |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
This pull request did not target the following hotfix branch(es) so they
Please check the status of the associated issue S3UTILS-241. Goodbye jonathan-gramain. The following options are set: approve |
Summary
content-lengthinhttpRequestbeing set to string character count instead of byte length, causing truncated writes when the body contains multi-byte UTF-8 characters (e.g. object keys with non-ASCII characters)httpRequest(GET and POST with multi-byte UTF-8 body) andputObjectMetadata(success, malformed URL, non-200 response)Test plan
yarn test:unitpassesputObjectMetadatawith non-ASCII object keys no longer produces truncated metadata in bucketd🤖 Generated with Claude Code