Skip to content

S3UTILS-242: add repairedInfo metadata field on object repair#401

Open
jonathan-gramain wants to merge 2 commits into
development/1.17from
improvement/S3UTILS-242-object-repair-mark-repaired-metadata
Open

S3UTILS-242: add repairedInfo metadata field on object repair#401
jonathan-gramain wants to merge 2 commits into
development/1.17from
improvement/S3UTILS-242-object-repair-mark-repaired-metadata

Conversation

@jonathan-gramain

Copy link
Copy Markdown
Contributor

Summary

  • When repairObject repairs a version with duplicate sproxyd keys, it now stamps a repairedInfo field on the metadata containing an ISO 8601 timestamp (lastRepairedAt) and the repair reason ("duplicate-sproxyd-keys")
  • This serves as a forensic marker to identify and correlate objects that were touched by the repair tool
  • Documents the new field in the README under the "Repair duplicate sproxyd keys" section

Test plan

  • Verify existing unit tests for repairObject / putObjectMetadata still pass (yarn test:unit)
  • Confirm the repairedInfo field is present in metadata after a repair by inspecting the object via the bucketd API
  • Confirm a second repair overwrites (not appends) the field

🤖 Generated with Claude Code

jonathan-gramain and others added 2 commits June 17, 2026 18:03
When repairObject repairs a version with duplicate sproxyd keys, it
now stamps a repairedInfo field on the metadata with a timestamp and
the reason, to aid forensic investigation of repaired objects.
Document the new field in README.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Hello jonathan-gramain,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.91%. Comparing base (a16c506) to head (4f9dd84).

Files with missing lines Patch % Lines
repairDuplicateVersionsSuite.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           development/1.17     #401      +/-   ##
====================================================
- Coverage             44.92%   44.91%   -0.01%     
====================================================
  Files                    88       88              
  Lines                  6462     6463       +1     
  Branches               1354     1354              
====================================================
  Hits                   2903     2903              
- Misses                 3513     3514       +1     
  Partials                 46       46              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants