Skip to content

[Sprint] sprint-loop-44 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scealiontach merged 3 commits into from
May 13, 2026
Merged

[Sprint] sprint-loop-44 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
869bae8
test(log): cover LOG_LEVEL zero source overrides (SUR-2855)
scealiontach May 13, 2026
3f94bd2
refactor(make): remove unused standard definitions (SUR-2841)
scealiontach May 13, 2026
9888a19
docs: update build target docs
scealiontach May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ jobs:
run: make package

# Jenkins' Analyze stage ran `make analyze` with FOSSA_API_KEY injected
# by Jenkins credentials. `make analyze` is currently a no-op in this
# repo (see standard_defs.mk), but we keep the stage wired up and
# gated on the FOSSA_API_KEY repository secret so PRs from forks (and
# any environment without the secret) skip it cleanly.
# by Jenkins credentials. `make analyze` is an explicit no-op in this
# repo, but we keep the stage wired up and gated on the FOSSA_API_KEY
# repository secret so PRs from forks (and any environment without the
# secret) skip it cleanly.
- name: Analyze (FOSSA, gated)
if: ${{ env.FOSSA_API_KEY != '' }}
run: make analyze
Expand Down Expand Up @@ -122,10 +122,9 @@ jobs:

- name: Publish via gh release
env:
# `make publish` runs `gh release create/upload` inside the
# toolchain image. It only acts when standard_defs.mk's RELEASABLE
# flag is "yes" (i.e. exactly on a clean tagged commit), so a plain
# push to main without a new tag is a no-op — same semantics as the
# legacy Jenkins job.
# `make publish` runs `gh release create/upload`. It only acts when
# standard_defs.mk's RELEASABLE flag is "yes" (i.e. exactly on a
# clean tagged commit), so a plain push to main without a new tag is
# a no-op — same semantics as the legacy Jenkins job.
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: make clean publish
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ Published targets:
| `build` | Compile / assemble artefacts |
| `test` | Run bats library specs and sprint regression scripts |
| `package` | Build all three tarballs into `dist/` |
| `analyze` | Run FOSSA licence analysis (requires `FOSSA_API_KEY`) |
| `analyze` | Explicit no-op kept for CI compatibility |
| `archive` | Upload artefacts to a release archive |
| `publish` | Tag-driven `gh release` upload (see `RELEASABLE` below) |
| `gh-create-draft-release` | Create a draft GitHub release |
Expand All @@ -138,5 +138,3 @@ Published targets:
tag (`LONG_VERSION != VERSION` because `git describe --long` always appends
the commit-count suffix) **and** the working tree is clean. `make publish`
gate-checks this flag before uploading.

The toolchain image is `blockchaintp/toolchain:latest`.
Loading
Loading