Skip to content

Onboard to distgen#380

Draft
ndavidova wants to merge 13 commits into
masterfrom
ndavidov/distgen
Draft

Onboard to distgen#380
ndavidova wants to merge 13 commits into
masterfrom
ndavidov/distgen

Conversation

@ndavidova
Copy link
Copy Markdown

@ndavidova ndavidova commented May 18, 2026 •
edited by github-actions Bot
Loading

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 905b2b8e-e9bc-4ad6-a03f-71f12555adbd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ndavidov/distgen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026 •
edited
Loading

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed

Triggered by Workflow Run

@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ndavidova ndavidova changed the title Ndavidov/distgen Onboard to distgen May 18, 2026
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

[test]

ndavidova added 4 commits May 18, 2026 21:21
@ndavidova
Remove CentOS Stream 8 support (EOL)
f0660b5
@ndavidova
regenerate version table
3e9c492
@ndavidova
Fix empty RUN command in Dockerfile template
28b87ba 
Use Jinja2 conditional to handle empty environment_setup properly.
When environment_setup is empty (Fedora, C10S, RHEL10), generate
'RUN INSTALL_PKGS=...' instead of 'RUN \n    INSTALL_PKGS=...'
which caused build failures.
@ndavidova
Use JSON array format for CMD to suppress Docker warning
2adbe56 
Changed from 'CMD $STI_SCRIPTS_PATH/usage' to 'CMD ["/usr/libexec/s2i/usage"]'
to follow Docker best practices and prevent build warnings from breaking
image ID extraction in build scripts.
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 18, 2026

[test-pytest]

@ndavidova ndavidova force-pushed the ndavidov/distgen branch 2 times, most recently from ecc73cf to abbd1ed Compare May 25, 2026 13:27
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 25, 2026

[test]

@sclorg sclorg deleted a comment from github-actions Bot May 27, 2026
@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 27, 2026

[test]

@ndavidova
Copy link
Copy Markdown
Author

ndavidova commented May 28, 2026

The API limit is exceeded but it looks like the tests passed (https://github.com/sclorg/nginx-container/actions/runs/26502076438), could I ask you for review @phracek?

I am not sure about rhel9 - 1.20, I see it in the list 'RHEL 9 Full Life Application Streams Release Life Cycle', but when I run yum module list nginx in rhel9.9 VM it lists 1.22, 1.24 and 1.26 and previously the test failed on the install step for rhel9 - 1.20 combination. How to navigate it? Does it make sense to remove rhel9 from 1.20?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr/missing-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ndavidova