feat(doas): new completion#766
Conversation
|
Makes sense, thanks for the explanation!
|
ghost
mentioned this pull request
| if [[ ${words[i]} != -* ]]; then | ||
| local PATH=$PATH:/sbin:/usr/sbin:/usr/local/sbin | ||
| local root_command=${words[i]} | ||
| _command_offset $i |
There was a problem hiding this comment.
In a similar way to_comp_root_command() (defined in bash_completion), I think we want to enable the completion as if the current user has root privilege.
| _command_offset $i | |
| local _comp_root_command=1 | |
| _command_offset $i |
|
Please confirm that you have no intention in merging or supporting bash completions in opendoas. Otherwise bash-completions the project, refuses to merge the bash-completion profile for doas. It's stuck for 3 years now. |
|
In case, the upstream issue is Duncaen/OpenDoas#62. The upstream PR is Duncaen/OpenDoas#84. |
|
The upstream issue and patch have been ignored for four years. I think that's enough evidence of lack of interest from upstream |
|
I agree the upstream asks have been open for more than long enough. Removed the related label, this PR and review can continue now. |
4 participants
Fix #505