Skip to content

Implement Auto suggestions #610

Merged
andrewtavis merged 7 commits into
scribe-org:mainfrom
angrezichatterbox:feat/implement-auto-suggestion
Jun 8, 2026
Merged

Implement Auto suggestions #610
andrewtavis merged 7 commits into
scribe-org:mainfrom
angrezichatterbox:feat/implement-auto-suggestion

Conversation

@angrezichatterbox

Copy link
Copy Markdown
Member

Contributor checklist


Description

This PR implements the autosuggestion in the Scribe-Android Keyboard.

Related issue

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Android rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

So amazing to have this open, @angrezichatterbox! 💙

@andrewtavis

Copy link
Copy Markdown
Member

I'll try to get to the review on Saturday :)

@angrezichatterbox

Copy link
Copy Markdown
Member Author

I'll try to get to the review on Saturday :)

I have kept the Android file licenses as it is. That would be fine right.

@andrewtavis

Copy link
Copy Markdown
Member

I think that that would be appropriate. Thanks for flagging this! We definitely should have an expansive reference, and this seems like an appropriate way to do it :)

@andrewtavis

Copy link
Copy Markdown
Member

Looks like there's a minor conflict here now, @angrezichatterbox :) Can we resolve that and then I'll look to bring this in next? 😊

@angrezichatterbox angrezichatterbox force-pushed the feat/implement-auto-suggestion branch from 897af6b to 285b38b Compare June 7, 2026 10:32
@angrezichatterbox

Copy link
Copy Markdown
Member Author

@andrewtavis it is ready for review.

@andrewtavis

Copy link
Copy Markdown
Member

Thanks, @angrezichatterbox! I'll get to this sometime today :)

@andrewtavis

Copy link
Copy Markdown
Member

Autosuggestions are working really well, @angrezichatterbox :) One thing to note though is that this is now breaking noun annotations. This isn't an issue with the data, as when I execute a plural command I still get a PL annotation. Can you look into why the noun annotations aren't being displayed?

@andrewtavis

Copy link
Copy Markdown
Member

I'm realizing that the above is an issue on main as well... I'll look to bring this in and then we can handle this in #521 :)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This really is a massive undertaking, @angrezichatterbox :) Great work to get all of this set up!

note: We should discuss sometime this week how we want to make sure that these files are maintainable. Maybe we need to remove some of the files that we're not using as they're for languages that we don't have implemented right now? Let's discuss in the call later this week 😊

@andrewtavis andrewtavis merged commit 744369d into scribe-org:main Jun 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants