Implement Auto suggestions #610
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
So amazing to have this open, @angrezichatterbox! 💙 |
|
I'll try to get to the review on Saturday :) |
I have kept the Android file licenses as it is. That would be fine right. |
|
I think that that would be appropriate. Thanks for flagging this! We definitely should have an expansive reference, and this seems like an appropriate way to do it :) |
|
Looks like there's a minor conflict here now, @angrezichatterbox :) Can we resolve that and then I'll look to bring this in next? 😊 |
897af6b to
285b38b
Compare
|
@andrewtavis it is ready for review. |
|
Thanks, @angrezichatterbox! I'll get to this sometime today :) |
|
Autosuggestions are working really well, @angrezichatterbox :) One thing to note though is that this is now breaking noun annotations. This isn't an issue with the data, as when I execute a plural command I still get a |
|
I'm realizing that the above is an issue on main as well... I'll look to bring this in and then we can handle this in #521 :) |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: This really is a massive undertaking, @angrezichatterbox :) Great work to get all of this set up!
note: We should discuss sometime this week how we want to make sure that these files are maintainable. Maybe we need to remove some of the files that we're not using as they're for languages that we don't have implemented right now? Let's discuss in the call later this week 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR implements the autosuggestion in the Scribe-Android Keyboard.
Related issue