Implement conjugate verbs search bar #566#611
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
angrezichatterbox
left a comment
There was a problem hiding this comment.
Great work @prince-0408. Everything functions as the requirements. Looking forward to see you contribute to more issues. I will merge this in @andrewtavis
|
Thanks for the great work, @prince-0408! |
|
Also thanks for the review and merging in, @angrezichatterbox :) |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR implements the Conjugate Verbs Search Bar feature for Scribe Conjugate, matching the layout and styling seen in the Figma design designs.
Key Changes:
ConjugateViewModelto handle search logic and querying across downloaded SQLite databases (*ConjugateData.sqlite) on a background thread (Dispatchers.IO).SharedPreferences(up to 15 items, newest first).ConjugateScreento feature the header and orange rectangular search bar with curved corners (RoundedCornerShape(dimensionResource(id = R.dimen.rounded_corner_radius_standard)), which is14.dpto match standard cards).verb (Deutsch).FontWeight.Boldand black.BasicTextFieldusingAlignment.CenterStartbox alignment.21.dpx18.dpto maintain its aspect ratio.Visual Comparison:
Testing Details:
ConjugateViewModelTestverifying:SharedPreferences.Related issue