Normalize index identifiers on construction#142
Open
crtschin wants to merge 1 commit into
Open
Conversation
Index column identifiers are stripped of outer quotes at construction. Indexes created by older versions still validate via a reconstructed legacy name candidate.
crtschin
force-pushed
the
dev-crtschin-legacy-checks
branch
from
3f6bb35 to
37c70e4
Compare
Collaborator
|
Is it actually the case that #136 was unnecessary since putting select columns in parentheses was possible before? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My changes in #136 didn't account for legacy indices that used a workaround to get columns with non-reserved keywords by explicitly quoting them in the includes. These indices historically got generated names with the
"converted into$.This PR changes it so index column identifiers are stripped of outer quotes at construction. Indexes created by older versions still validate via a reconstructed legacy name candidate.