Remove spatial interlacement prototype from palette generation#586
Merged
Remove spatial interlacement prototype from palette generation#586
Conversation
The spatial-aware color assignment (interlacement matrix + KDTree neighbor weighting) was a prototype that added complexity without being ready for production use. Remove it and keep the general contrast maximization methods (Oklab perceptual distance, CVD simulation, permutation optimizer with uniform weights). make_palette_from_data retains category extraction from SpatialData elements and all non-spatial methods (default, contrast, colorblind, protanopia, deuteranopia, tritanopia). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 76.44% 76.22% -0.23%
==========================================
Files 11 11
Lines 3261 3188 -73
Branches 759 750 -9
==========================================
- Hits 2493 2430 -63
+ Misses 466 461 -5
+ Partials 302 297 -5
🚀 New features to boost your workflow:
|
- _get_labels_from_table now returns only labels (pd.Series), removing the instance-key join and index-alignment logic that was only needed for coordinate extraction - Simplify _build_clustered_points_sdata fixture: the specific spatial geometry was only meaningful for the removed spatial interlacement tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_spatial_interlacementmake_palette_from_dataretains category extraction from SpatialData elements and all non-spatial methods (default,contrast,colorblind,protanopia,deuteranopia,tritanopia)