Add SQL test triage guide and focused test rerun make targets#56
Merged
seanwevans merged 2 commits intoMay 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
docs/test-triage.mdwith sections for capturing the first failing test, how to rerun a single SQL test file, failure classification (logic bug, migration drift, env/setup, nondeterminism), required artifacts per failure, a post-fix isolation checklist, and a small known-failures tracking table.makefileto add focused test helpers:test-one(run one SQL test viaTEST=...),test-one-verbose(verbose single-file run), andtest-list(print the orderedTESTSlist), and expanded.PHONYaccordingly while preserving the existingtesttarget.test-listrecipe prints$(TESTS)correctly when invoked.Testing
test-listrecipe is present and prints theTESTSlist when the environment provides PGXS.make test-listin the current environment which failed because the host is missing the PostgreSQL PGXS include (/usr/lib/postgresql/16/lib/pgxs/src/makefiles/pgxs.mk), so fullmakeinvocation could not be executed here.Codex Task