Fix test target coverage and add single-test runners#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test/sql/search_path_qualification_test.sqlwas present in the manifest but not included in the default core test list, causing inconsistent default coverage.Makefilelackedtest-one/test-one-verbose, making local triage harder.Description
test/sql/search_path_qualification_test.sqlto theCORE_TESTSlist so it runs as part of the defaultmake testflow.test-oneandtest-one-verboseMake targets that run a single SQL test file usingpg_proveand include usage guards whenTESTis unset..PHONYto include the new targets and placed the new targets in theMakefileafter the existingtest-alltarget.Testing
pytest -q, which reported that no pytest tests exist in this repository (no tests ran).make test, which could not run the SQL test harness in this environment due to a missing PGXS include file at/usr/lib/postgresql/16/lib/pgxs/src/makefiles/pgxs.mk, sopg_prove-based tests were not executed here.Codex Task