Makefile: add PG_PROVE wrapper and check-pg_prove preflight for SQL tests#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-d postgres.pg_proverunner is not available.Description
PG_PROVEwrapper that forwardsPGHOST,PGPORT,PGUSER, andPGDATABASEinto thepg_proveinvocation.check-pg_provepreflight target that verifiespg_proveis present and emits an actionable install hint when missing.test-core,test-integration,test-performance,test-one, andtest-one-verbosedepend oncheck-pg_proveand use$(PG_PROVE)(including--verbosefor the verbose runner).Testing
pytest -qwhich discovered no Python tests in this repository.make test-corein this environment and it now fails early with the preflight messagepg_prove not found. Install pgTAP test runner (e.g., apt install libtap-parser-sourcehandler-pgtap-perl).and exits with code 127, demonstrating the preflight check is working.pg_proveor PGXS build files.Codex Task