Skip to content

Request Registry Class#4953

Merged
gpotter2 merged 1 commit intosecdev:masterfrom
Ebrix:master
Mar 23, 2026
Merged

Request Registry Class#4953
gpotter2 merged 1 commit intosecdev:masterfrom
Ebrix:master

Conversation

@Ebrix
Copy link
Contributor

@Ebrix Ebrix commented Mar 23, 2026

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I unit tests are part of scapy-red
  • I executed the regression tests (using tox)
  • If the PR is still not finished, please create a Draft Pull Request

The PR is fixing the information request to the class name of the registry. By default, we request a classname of 0b, but we need to re-request it with proper size if Windows returned >2B size.

@Ebrix Ebrix marked this pull request as ready for review March 23, 2026 16:20
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (b1add1f) to head (f0faa92).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/windows/registry.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4953      +/-   ##
==========================================
- Coverage   80.30%   79.76%   -0.55%     
==========================================
  Files         379      379              
  Lines       93102    93107       +5     
==========================================
- Hits        74767    74265     -502     
- Misses      18335    18842     +507     
Files with missing lines Coverage Δ
scapy/layers/windows/registry.py 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit 04b99c3 into secdev:master Mar 23, 2026
20 of 24 checks passed
@gpotter2
Copy link
Member

Thanks for the PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants