Devirtualize IFDS/IDE Tabulation Problem#851
Open
fabianbs96 wants to merge 43 commits into
Open
Conversation
…te into IDESolver/IFDSSolver (Not testsed yet!)
fabianbs96
marked this pull request as ready for review
July 18, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual polymorphism is not necessary for the IFDS/IDE analysis problems. The polymorphism is restricted anyway by the
AnalysisDomainTytemplate param (every IDE problem has its own), and the virtual calls can prevent compiler optimizations in hot parts of the code.This PR adds numerous concepts + some mixins to replace the virtual interfaces. Most important ones:
IFDSProblem,IDEProblemIFDSProblemWrapper,IDEProblemWrapper,IfdsIdeProblemWrapperIfdsToIdeProblemAdapterIfdsIdeProblemMixinLegacyIDEProblemWrapper, used in theIDESolver; theIterativeIDESolverdoesn't need thisInheriting from a specific base class is now optional; Use
IfdsIdeProblemMixininstead ofIFDSTabulationProblemorIDETabulationProblemto reduce some boilerplate.This PR additionally de-virtualizes all IFDS/IDE problem descriptions provided by phasar.