all: fold the otlp package back into the main module - #225
Merged
Conversation
wavetylor
approved these changes
Jul 29, 2026
|
thank you! |
The nested otlp/go.mod meant `go test ./...`, `go build ./...`, and golangci-lint at the repo root all silently skipped the otlp package, and every dependency bump had to be applied in two places. Remove it and let otlp be an ordinary package of github.com/segmentio/stats/v5. The cost is the module's minimum Go version: the OpenTelemetry SDK and gRPC both declare `go 1.25.0`, so the root go.mod moves from 1.24.0 to 1.25.0 and every consumer of stats now pulls in the OTel SDK and gRPC. CI's oldstable is already 1.25, so the test matrix is unaffected. Now that the package is actually linted, fix the 17 issues it had been hiding: missing periods on declaration comments (godot), an import group that ignored the local-prefixes setting (goimports), "signalled" -> "signaled" (misspell), unused parameters (revive), and an unused resourceAttrs field on SDKHandler. recordMetric's metricName parameter was never read, so it is dropped rather than renamed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kevinburkesegment
force-pushed
the
unnest-otlp-module
branch
from
July 29, 2026 17:57
15dedc0 to
5ff45e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nested otlp/go.mod meant
go test ./...,go build ./..., and golangci-lint at the repo root all silently skipped the otlp package, and every dependency bump had to be applied in two places. Remove it and let otlp be an ordinary package of github.com/segmentio/stats/v5.The cost is the module's minimum Go version: the OpenTelemetry SDK and gRPC both declare
go 1.25.0, so the root go.mod moves from 1.24.0 to 1.25.0 and every consumer of stats now pulls in the OTel SDK and gRPC. CI's oldstable is already 1.25, so the test matrix is unaffected.Now that the package is actually linted, fix the 17 issues it had been hiding: missing periods on declaration comments (godot), an import group that ignored the local-prefixes setting (goimports), "signalled" -> "signaled" (misspell), unused parameters (revive), and an unused resourceAttrs field on SDKHandler. recordMetric's metricName parameter was never read, so it is dropped rather than renamed.