Skip to content

Fix cosmos limit big integer range#2415

Merged
masih merged 1 commit into
mainfrom
masih/sei-cosmos-594
Sep 30, 2025
Merged

Fix cosmos limit big integer range#2415
masih merged 1 commit into
mainfrom
masih/sei-cosmos-594

Conversation

@masih
Copy link
Copy Markdown
Collaborator

@masih masih commented Sep 30, 2025

Ports over the work originally done in sei-protocol/sei-cosmos#594.

Relates to:

## Describe your changes and provide context

## Testing performed to validate your change
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.66%. Comparing base (06a4e24) to head (d5468fc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-cosmos/types/decimal.go 83.63% 7 Missing and 2 partials ⚠️

❌ Your project status has failed because the head coverage (36.66%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
+ Coverage   36.64%   36.66%   +0.01%     
==========================================
  Files        1165     1165              
  Lines      104350   104355       +5     
==========================================
+ Hits        38242    38263      +21     
+ Misses      62848    62841       -7     
+ Partials     3260     3251       -9     
Files with missing lines Coverage Δ
sei-cosmos/types/decimal.go 67.30% <83.63%> (+2.71%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

// assertInValidRange panics if the decimal is out of the valid range
func (d Dec) assertInValidRange() {
if !d.IsInValidRange() {
panic("decimal out of range")

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@masih masih marked this pull request as ready for review September 30, 2025 14:24
@masih masih changed the title fix: limit big integer range (#594) Fix cosmos limit big integer range Sep 30, 2025
@masih masih enabled auto-merge (squash) September 30, 2025 15:11
@masih masih merged commit ef0bb14 into main Sep 30, 2025
71 of 74 checks passed
@masih masih deleted the masih/sei-cosmos-594 branch September 30, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants