Skip to content

Tidy app gas accounting loop and tests#3464

Open
masih wants to merge 1 commit into
mainfrom
masih/tidy-app
Open

Tidy app gas accounting loop and tests#3464
masih wants to merge 1 commit into
mainfrom
masih/tidy-app

Conversation

@masih
Copy link
Copy Markdown
Collaborator

@masih masih commented May 19, 2026

  • Remove nonzeroTxsCnt: declared and incremented but never read.
  • Remove a stale "Skipping" inline comment that no longer describes
    the branch it sits next to.
  • Reduce allocations and optimise for fast path on decode failure.

- Remove `nonzeroTxsCnt`: declared and incremented but never read.
- Remove a stale "Skipping" inline comment that no longer describes
  the branch it sits next to.
- Reduce allocations and optimise for fast path on decode failure.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 19, 2026, 2:24 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.30%. Comparing base (1b89b44) to head (358b09a).

Files with missing lines Patch % Lines
app/app.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   59.30%   59.30%   -0.01%     
==========================================
  Files        2127     2127              
  Lines      175877   175868       -9     
==========================================
- Hits       104301   104293       -8     
+ Misses      62489    62488       -1     
  Partials     9087     9087              
Flag Coverage Δ
sei-chain-pr 50.28% <87.50%> (?)
sei-db 70.62% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 69.23% <87.50%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review May 19, 2026 14:24
@masih masih requested review from arajasek and sei-will May 19, 2026 14:24
@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Medium Risk
Touches proposal-time block gas accounting. Changes are small and covered by updated/new unit tests, but the code sits on the consensus-critical proposal acceptance path.

Overview
Proposal-time block gas validation is tightened and simplified. checkTotalBlockGas now rejects proposals immediately, adds explicit uint64 overflow guards for lint issues, and streamlines MaxGas/MaxGasWanted checks.

Gasless heuristics/tests are cleaned up. couldBeGaslessTransaction is simplified to a single conservative message-type check, and the test suite is refactored with reusable helpers.

Reviewed by Cursor Bugbot for commit 358b09a. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant