Migrate goreleaser workflow to call uci reusable#180
Conversation
Replaces the standalone GoReleaser job with a thin caller that delegates
to sei-protocol/uci's new goreleaser-release reusable workflow.
- .goreleaser.yaml is unchanged; no behavioural change to release outputs
- Same triggers (release: published, workflow_dispatch, workflow_run on
'Releaser') so the existing version.json -> uci release-publish ->
goreleaser flow keeps working
- go-version-file: go.mod retained
- checkout-latest-tag passed for the workflow_run path so we tag-build
after the GitHub Release is created by uci's release-publish
Once the uci PR adding goreleaser-release.yml is merged and tagged,
update the @ref here to a version tag instead of the feature branch.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a7d2684. Configure here.
| args: release --clean | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} No newline at end of file | ||
| uses: sei-protocol/uci/.github/workflows/goreleaser-release.yml@monty/goreleaser-reusable-workflow |
There was a problem hiding this comment.
Reusable workflow pinned to ephemeral feature branch
High Severity
The uses reference points to a mutable feature branch (@monty/goreleaser-reusable-workflow) rather than a pinned tag. Every other reusable workflow call in this repo is pinned to @v0.0.3. Once the upstream PR (uci#35) merges, this branch will likely be deleted, causing the workflow to fail with a "ref not found" error on every release. The PR description acknowledges this needs to be bumped to a tag before merge, but the workflow as committed would break if merged in its current state.
Reviewed by Cursor Bugbot for commit a7d2684. Configure here.
|
This looks good to me but just needs the personal branch you used for testing to be removed |
2 participants
Replaces the standalone GoReleaser job with a thin caller that delegates to sei-protocol/uci's new
goreleaser-releasereusable workflow..goreleaser.yamlis unchanged; no behavioural change to release outputs. Same triggers (release: published,workflow_dispatch,workflow_runon 'Releaser'), so the existingversion.json→ ucirelease-publish→ goreleaser flow keeps working.Dependency: Blocked on sei-protocol/uci#35. Once that PR merges and uci is tagged, this PR's
@refbumps from@monty/goreleaser-reusable-workflowto the new uci tag.Refs PLT-41.
Note
Low Risk
Low risk: this is a CI workflow refactor that delegates the existing GoReleaser steps to a reusable workflow; main risk is release automation breakage if the external workflow ref/inputs change.
Overview
Replaces the in-repo
GoReleaserGitHub Actions job (checkout, optional latest-tag checkout, setup-go, goreleaser action) with a thin wrapper that callssei-protocol/uci’s reusablegoreleaser-releaseworkflow.Preserves the same triggers (
release: published,workflow_dispatch, andworkflow_runonReleaser) and passesgo-version-fileplus acheckout-latest-tagflag for theworkflow_runpath.Reviewed by Cursor Bugbot for commit a7d2684. Bugbot is set up for automated code reviews on this repo. Configure here.