[fix] Resolved TypingIndicator.tsx bug not cleaning up newHandlerId

[rob-ryszewski]

Summary

TypingIndicator.tsx has a useEffect that does:

const newHandlerId = uuidv4();
sb.groupChannel.addGroupChannelHandler(newHandlerId, handler);
setHandlerId(newHandlerId);

Yet in that useEffect's cleanup function, it targets removing handlerId instead of newHandlerId:

sb.groupChannel.removeGroupChannelHandler(handlerId);

This causes TypingIndicator to leak group channel handlers that stay subscribed and un-removed.

I came across this in a scenario where this compounded and caused many leaked handlers that then led to other issues.

Fix

sb.groupChannel.removeGroupChannelHandler(newHandlerId ?? handlerId);

To defensively cover the scenario were sb.groupChannel.addGroupChannelHandler is not defined, and the code never instantiates a newHandlerId, it falls back to ?? handlerId.

Checklist

• All tests pass locally with my changes

[netlify]

👷 Deploy request for sendbird-uikit-react pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	8d45471

[rob-ryszewski]

@sf-tyler-jeong could I get your review? 3 line bugfix to stop leaking handlers, potentially unboundedly