Make all KPAR sources have kpar_digest and src sources have checksum#352
Open
andrius-puksta-sensmetry wants to merge 4 commits into
Open
Make all KPAR sources have kpar_digest and src sources have checksum#352andrius-puksta-sensmetry wants to merge 4 commits into
andrius-puksta-sensmetry wants to merge 4 commits into
Conversation
b4a2859 to
6cb572e
Compare
34f5ce5 to
840de01
Compare
…source kpar/src checksums Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
840de01 to
e3ac726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
checksumfrom lockfile project entries.*_srcsources now all carrychecksumkpar_path/*_kparsources now all carrykpar_sizeandkpar_digestOverrideSourcemodel, since config records user-provided source locations while lockfiles record resolved sources with integrity metadata.Added
ProjectChecksum, distinguishing canonical source-project checksums from KPAR archive checksums. It is tied rather closely toenv.tomlstructure, so otherReadEnvironmentimplementers currrently stub out the methods.src_cksum/kpar_cksummetadata in local environment project entries to remember what kind of source the project was installed from. This means that currently we have no way to verify correctness of projects withkpar_cksum, as the actual KPAR is not savedChanged
syncnow decides whether a project is already installed by checking each lockfile source checksum against the environment, rather than comparing a single project-level checksum.syncinstalls projects using the checksum kind associated with the selected source.syncnow matches by project version instead of project checksum.Fixed
env.tomlis written and later another project is being installedCloses #325.
Closes #326.