feat(build): update index and checksum by default, provide opt out for index#382
Open
andrius-puksta-sensmetry wants to merge 1 commit into
Open
Conversation
andrius-puksta-sensmetry
force-pushed
the
pr/update-index-checksum
branch
2 times, most recently
from
2820b5f to
c08b6cf
Compare
…r index This reverts the default flip done by sensmetry#298. Index-only opt-out is provided, since it doesn't make sense to not update checksums to match actual file contents. Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
andrius-puksta-sensmetry
force-pushed
the
pr/update-index-checksum
branch
from
c08b6cf to
f73e8f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the default flip done by #298. Index-only opt-out is provided, since it doesn't make sense to not update checksums to match actual file contents. Java bindings (and only these) will not update index, as the user can supply custom project metadata, including index, and updating the index silently on build would override the supplied one.
Now the behaviour matches user expectations in almost all cases, and requires less friction to build KPARs publishable to the index.
In bindings, also allow path usages in the KPARs being built, since this is not yet configurable by the caller.
Fixes #378