Only call eglMakeCurrent if anything has changed in CurrentContextGuard::drop#360
Queued
mrobinson wants to merge 1 commit into
Queued
Only call eglMakeCurrent if anything has changed in CurrentContextGuard::drop#360mrobinson wants to merge 1 commit into
eglMakeCurrent if anything has changed in CurrentContextGuard::drop#360mrobinson wants to merge 1 commit into
Conversation
jdm
reviewed
Jun 3, 2026
|
|
||
| // Only call eglMakeCurrent again if anything has changed. | ||
| if egl.GetCurrentDisplay() == self.egl_display | ||
| && egl.GetCurrentSurface(egl::DRAW as EGLint) != self.old_egl_draw_surface |
Member
There was a problem hiding this comment.
Why are we using != for two if these checks?
Member
Author
There was a problem hiding this comment.
Oops. I accidentally uploaded an old version of this change. This should be addressed now.
Member
|
What is the effect of these changes? |
…Guard::drop` Instead of unconditionally calling `eglMakeCurrent` when restoring the context in `CurrentContextGuard::drop` only do this if anything has changed. This guards against drivers that do too much when calling `eglMakeCurrent`. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
mrobinson
force-pushed
the
lightweight-context-guard
branch
from
24c6928 to
3057231
Compare
Member
Author
In the end I think this depends on what the driver does when you call |
jdm
approved these changes
Jun 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of unconditionally calling
eglMakeCurrentwhen restoring thecontext in
CurrentContextGuard::droponly do this if anything haschanged. This guards against drivers that do too much when calling
eglMakeCurrent.