Skip to content

fix: click whatever you can on chrome first open #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikimandoki merged 2 commits into from
Apr 7, 2026
Merged

fix: click whatever you can on chrome first open #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
234c5ce
fix: click whatever you can on chrome first open
mikimandoki Apr 7, 2026
e558fbb
fix: simplify logic
mikimandoki Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions run/test/utils/handle_first_open.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,28 @@ import { DeviceWrapper } from '../../types/DeviceWrapper';
import { ChromeNotificationsNegativeButton, ChromeUseWithoutAnAccount } from '../locators/browsers';
import { iOSPhotosContinuebutton } from '../locators/external';

// First time open of Chrome triggers an account check and a notifications modal
// First time open of Chrome triggers an account check and a notifications modal.
// If the account check appears, notifications will follow after dismissing it (not detectable upfront).
// If someone already pressed the "Use without an account" button, only the notifications prompt may appear.
export async function handleChromeFirstTimeOpen(device: DeviceWrapper) {
const chromeUseWithoutAnAccount = await device.doesElementExist({
...new ChromeUseWithoutAnAccount(device).build(),
maxWait: 5_000,
});
if (!chromeUseWithoutAnAccount) {
device.log('Chrome opened without an account check, proceeding');
} else {
device.log(
'Chrome has been opened for the first time, dismissing account use and notifications'
);
const [useWithoutAccount, notifications] = await Promise.all([
device.doesElementExist({ ...new ChromeUseWithoutAnAccount(device).build(), maxWait: 5_000 }),
device.doesElementExist({
...new ChromeNotificationsNegativeButton(device).build(),
maxWait: 5_000,
}),
]);

if (!useWithoutAccount && !notifications) {
device.log('Chrome opened normally, proceeding');
return;
}

device.log('Chrome has been opened for the first time, dismissing modals');
if (useWithoutAccount) {
await device.clickOnElementAll(new ChromeUseWithoutAnAccount(device));
await device.clickOnElementAll(new ChromeNotificationsNegativeButton(device));
}
await device.clickOnElementAll(new ChromeNotificationsNegativeButton(device));
}

export async function handlePhotosFirstTimeOpen(device: DeviceWrapper) {
Expand Down
Loading