chore: release v1.1026.0#12393
Open
kaladinlight wants to merge 12 commits into
Open
Conversation
…OKEN pnpm 10.30.3 fails the Publish step with "Unknown option: 'workspace-concurrency'" — the flag is documented for `pnpm -r` but rejected when the recursive subcommand is `publish`. Switch to `pnpm -r publish ...` with no concurrency flag (pnpm still walks the workspace graph in topological order). Also drops the redundant `GITHUB_TOKEN` env var from the tag step — `actions/checkout@v4` persists credentials by default, so `git push origin <tag>` already authenticates via the per-job token granted by `permissions: contents: write`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
npm Trusted Publishers OIDC attaches provenance automatically and rejects publishes whose package.json repository.url doesn't match the encoded repo URL. swap-widget and the hdwallet-* packages were missing the field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow needs manual approval to run. Since I already have all the data needed (commit list + full feature-flag analysis), I'll produce the notes directly.
My flag analysis: none of the v1.1026.0 commits map to a production-OFF feature flag. RFOX is ON in production, and there is no feature flag for affiliate, BTC speed-up, or asset data. So the dev/local-only section is empty.
Production changes - testing required
Affiliate fee split + registration
Affiliate registration is now a single
POST /v1/affiliatecall requiring bothpartnerCodeandbps(the standalone claim-code route and its dashboard UI are gone), and the on-chainaffiliateBpsis now split intopartnerBps+shapeshiftBpssnapshotted at quote time and forwarded consistently across web, public-api, swap-widget, and the affiliate dashboard. Test the full affiliate registration form (confirm only lowercase letters/digits, 3-32 chars are accepted forpartnerCode), then run a swap with an affiliate code and verify the fee split and totals display correctly in the quote and dashboard. Note: pairs with a companion microservices PR in a separate repo.Bitcoin speed-up (RBF)
Fixes BTC RBF speed-up signing failures caused by an incorrectly derived BIP44 path, and tightens the speed-up action UX. Send a BTC transaction, then speed it up (RBF) and confirm signing succeeds and the action flow behaves correctly.
rFOX
Keeps the WETH/FOX filter pill and "Program Ended" warning visible during the LP unstake cooldown-pending and ready-to-claim states (where staking balance is zero but the legacy UI is still needed). With an rFOX LP position, request an unstake and verify the WETH/FOX tab stays visible during cooldown and through claiming.
Fixes, deps, and infra
No testing required.
Asset data regeneration plus CI/packaging changes for automated npm publishing of public packages.
Dev/local only - no production testing required
None. No commits in this release are behind a feature flag that is off in production.
If you'd like me to run the verification workflow anyway (it drafts and adversarially double-checks the flag classification), approve the workflow prompt and I'll kick it off.