DNM: Add OCP upgrade stage for OSP 18#22
Open
dlaw4608 wants to merge 1 commit into
Open
Conversation
Port upgrade functionality from openshift-ir-plugin to support sequential OCP upgrades on OSP 18. Supports versions 4.16-4.23, automatically builds upgrade paths skipping unsupported versions like 4.17. Includes version-specific workarounds for 4.16 consoleplugins and 4.19 k8s API acknowledgment. Collects must-gather on failure. Change-Id: I8c0b804cb91774fb5bb5fccf47cdb6015d46d771 Signed-off-by: Daniel Lawton <dlawton@redhat.com>
Contributor
There was a problem hiding this comment.
Hey Daniel, the ansible-lint CI is failing with 3 violations in collection/stages/roles/upgrade/tasks/single_upgrade.yml:
1. risky-shell-pipe - line 86 (task: "Get the OCP release digest")
2. risky-shell-pipe - line 116 (task: "Wait until the upgrade starts (Progressing=True)")
Shell tasks using pipes need the pipefail option so failures in any part of the pipe are caught. Fix by prepending set -o pipefail && to the command:
- name: Get the OCP release digest
ansible.builtin.shell:
cmd: set -o pipefail && your_command | grep something3. jinja[spacing] - line 161 (warning, but blocks the required production profile)
Remove the extra spaces around the outer parentheses:
- {{ ( ((finish_time | to_datetime('%Y-%m-%dT%H:%M:%S')) - (start_time | to_datetime('%Y-%m-%dT%H:%M:%S'))).total_seconds() / 60 ) | int }}
+ {{ (((finish_time | to_datetime('%Y-%m-%dT%H:%M:%S')) - (start_time | to_datetime('%Y-%m-%dT%H:%M:%S'))).total_seconds() / 60) | int }}Once these 3 are fixed, CI should go green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port upgrade functionality from openshift-ir-plugin to support sequential
OCP upgrades on OSP 18. Supports versions 4.16-4.23
DNM: WIP still needs E2E test validation