feature: better Apple login messaging & code cleanup#222
Merged
madebydavid merged 1 commit intoJul 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #219 by adding trust-building messaging to the Apple login flow, explaining where credentials go and linking users to the relevant source code. It also simplifies Apple auth code by removing an indirection layer and improving the @expo/apple-utils ESM/CommonJS interop shim.
Changes:
- Add a rendered Markdown notice shown during
shipthis apple login(including when invoked by the iOS wizard). - Refactor Apple login to call
@expo/apple-utilsAuth.loginAsyncdirectly and remove the now-redundantsrc/apple/auth.ts. - Replace the previous “weird export issue” workaround with a clearer documented interop shim in
src/apple/expo.ts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/commands/apple/login.ts | Adds user-facing auth explanation + source links; refactors login to use Auth.loginAsync directly. |
| src/apple/expo.ts | Documents and centralizes ESM/CommonJS interop for @expo/apple-utils. |
| src/apple/auth.ts | Removes the previous auth wrapper module now made redundant by the refactor. |
| assets/markdown/apple-login-notice.md.ejs | Adds the Markdown notice content explaining the credential handling and linking to source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
read the review, but happy with the current state rather than the suggestions |
madebydavid
changed the title
madebydavid
deleted the
219-add-explanation-text-to-the-shipthis-apple-login-command-and-wizard-equivalent
branch
July 16, 2026 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #219
What's changed