Skip to content

feature: detecting Godot version drift and showing warning / error#225

Merged
madebydavid merged 1 commit into
mainfrom
217-upgraded-game---shipthis-still-uses-old-godot-version
Jul 16, 2026
Merged

feature: detecting Godot version drift and showing warning / error#225
madebydavid merged 1 commit into
mainfrom
217-upgraded-game---shipthis-still-uses-old-godot-version

Conversation

@madebydavid

Copy link
Copy Markdown
Member

This is to resolve #217

What's changed

  • if no gameEngineVersion specified when shipping then checking the persisted version against the detected version
  • If there is minor mismatch then it will show a warning
  • If there is a major mismatch then it will throw an error

@madebydavid madebydavid linked an issue Jul 16, 2026 that may be closed by this pull request
@madebydavid
madebydavid marked this pull request as ready for review July 16, 2026 14:07
@madebydavid
madebydavid requested a review from Copilot July 16, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a safeguard to detect when the Godot version recorded in the game’s persisted configuration has drifted from the Godot version implied by the local project.godot, warning or stopping a ship to prevent publishing builds with an incompatible engine version.

Changes:

  • Introduces detectGodotVersion() (null-safe wrapper) and getGodotVersionDrift() (major/minor drift detection) in the Godot utilities.
  • Adds pre-ship drift checking when --gameEngineVersion is not explicitly provided: warn on minor drift, error on major drift with actionable CLI guidance.
  • Adds unit tests covering version detection and drift classification.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/utils/godot.test.ts Adds test coverage for detectGodotVersion() and getGodotVersionDrift().
src/utils/ship/index.ts Performs drift detection during ship and emits warning/error plus fix instructions when needed.
src/utils/godot.ts Adds drift parsing/comparison helpers and a null-safe version detection wrapper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@madebydavid

Copy link
Copy Markdown
Member Author

no comments from the review

I will merge and then perform integration testing of the recent changes before making a release

@madebydavid
madebydavid merged commit 0ff280b into main Jul 16, 2026
1 check passed
@madebydavid
madebydavid deleted the 217-upgraded-game---shipthis-still-uses-old-godot-version branch July 16, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgraded game - ShipThis still uses old Godot version

2 participants