feature: detecting Godot version drift and showing warning / error#225
Merged
madebydavid merged 1 commit intoJul 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a safeguard to detect when the Godot version recorded in the game’s persisted configuration has drifted from the Godot version implied by the local project.godot, warning or stopping a ship to prevent publishing builds with an incompatible engine version.
Changes:
- Introduces
detectGodotVersion()(null-safe wrapper) andgetGodotVersionDrift()(major/minor drift detection) in the Godot utilities. - Adds pre-ship drift checking when
--gameEngineVersionis not explicitly provided: warn on minor drift, error on major drift with actionable CLI guidance. - Adds unit tests covering version detection and drift classification.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/utils/godot.test.ts | Adds test coverage for detectGodotVersion() and getGodotVersionDrift(). |
| src/utils/ship/index.ts | Performs drift detection during ship and emits warning/error plus fix instructions when needed. |
| src/utils/godot.ts | Adds drift parsing/comparison helpers and a null-safe version detection wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
no comments from the review I will merge and then perform integration testing of the recent changes before making a release |
madebydavid
deleted the
217-upgraded-game---shipthis-still-uses-old-godot-version
branch
July 16, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to resolve #217
What's changed