Add tests from smoketest PR (shutter-api/pull/107)#689
Draft
konradkonrad wants to merge 4 commits intomainfrom
Draft
Add tests from smoketest PR (shutter-api/pull/107)#689konradkonrad wants to merge 4 commits intomainfrom
konradkonrad wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that documents a shortcoming in event trigger definitions: currently we do not have expressions to match on array types other than
[]byte(i.e.uint256[], ...) in event data. Output from the failing test:It adds other test cases from shutter-network/shutter-api#107 that are passing.
Note: from my understanding the current implementation can not support
arraysand probably nostructtypes either, because we're missing the necessary type hints in the serialized event trigger definition for decoding these from event log data. If we find use cases with events that need support for these, we will need to add information toLogValueRefbeyond thebool Dynamicflag.