test(e2e): resolve flaky tour tests#2058
Open
chintankavathia wants to merge 16 commits into
Open
Conversation
…kerConfig BREAKING CHANGE: `CriterionDefinition.datepickerConfig` type narrowed The type of `datepickerConfig` in `CriterionDefinition` (filtered-search) changed from `DatepickerInputConfig` to `Omit<DatepickerInputConfig, 'enableDateRange' | 'enableTwoMonthDateRange'>`. The properties `enableDateRange` and `enableTwoMonthDateRange ` are no longer accepted in `datepickerConfig` when used with filtered-search criteria, as they had no effect in that context. Migration: Remove any `enableDateRange` and `enableTwoMonthDateRange` properties from your `datepickerConfig` objects passed to `CriterionDefinition`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a helper function 'waitForTourStep' in the 'si-tour' end-to-end test suite to encapsulate the visibility checks for tour elements, improving test readability and maintainability. The reviewer suggested scoping the CSS selectors to the 'si-tour' component to ensure better test robustness, which is a valid improvement opportunity.
chintankavathia
force-pushed
the
test/e2e/tour/flaky
branch
from
3f4bf5c to
de5de08
Compare
dr-itz
reviewed
May 18, 2026
| const waitForTourStep = async (hasArrow = true): Promise<void> => { | ||
| await expect(page.locator('si-tour .tour-content.show')).toBeVisible(); | ||
| if (hasArrow) { | ||
| await expect(page.locator('si-tour .popover-arrow')).toBeVisible(); |
Member
There was a problem hiding this comment.
will this help? I mean if step 1 has an arrow and step 2 has an arrow, I think it will remain visible but repositions
Member
Author
There was a problem hiding this comment.
just realized visibility of arrow is not a problem but the offset calculation gets wrong sometimes for the first step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tour e2e sometimes failing due to setTimeout in arrow pos calculation.
see https://github.com/siemens/element/actions/runs/25797160585
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: