feat(navbar-vertical-next): add inline collapse mode#2097
Open
mistrykaran91 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an 'inline collapse' feature for the vertical navbar, allowing the navigation content to become inert while the toggle button remains accessible in the page flow. Feedback focuses on resolving unit test failures caused by missing CSS classes in the implementation and improving test reliability by replacing manual timeouts with fixture.whenStable() to comply with the repository style guide. Additionally, a suggestion was made to use the native [inert] property binding for more idiomatic Angular code.
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
2 times, most recently
from
9ab1d22 to
5546113
Compare
spliffone
reviewed
May 26, 2026
spliffone
reviewed
May 26, 2026
spliffone
reviewed
May 26, 2026
spliffone
reviewed
May 26, 2026
spliffone
reviewed
May 26, 2026
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
from
9e7d0f3 to
26b02fc
Compare
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
from
8a15875 to
9d8a0b7
Compare
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
2 times, most recently
from
7426f9e to
871d93b
Compare
spliffone
approved these changes
May 27, 2026
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
from
871d93b to
0d5acb9
Compare
kfenner
approved these changes
May 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
- The collapse/expand icons are switched to elementLayoutPane2 / elementLayoutPane2Right when `inlineCollapse` mode - Updated example components and templates to include a control for inlineCollapse. Related #1945
mistrykaran91
force-pushed
the
feat/navbar-vertical-next-inline-collapse-portal
branch
from
6329127 to
266ef69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inlineCollapsemodeRelated #1945
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: