fix(filtered-search): omit daterange specific properties from datepickerConfig#2101
Draft
ljanner wants to merge 1 commit into
Draft
fix(filtered-search): omit daterange specific properties from datepickerConfig#2101ljanner wants to merge 1 commit into
ljanner wants to merge 1 commit into
Conversation
…kerConfig BREAKING CHANGE: `CriterionDefinition.datepickerConfig` type narrowed The type of `datepickerConfig` in `CriterionDefinition` (filtered-search) changed from `DatepickerInputConfig` to `Omit<DatepickerInputConfig, 'enableDateRange' | 'enableTwoMonthDateRange'>`. The properties `enableDateRange` and `enableTwoMonthDateRange ` are no longer accepted in `datepickerConfig` when used with filtered-search criteria, as they had no effect in that context. Migration: Remove any `enableDateRange` and `enableTwoMonthDateRange` properties from your `datepickerConfig` objects passed to `CriterionDefinition`.
ljanner
added
bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the datepickerConfig property in the CriterionDefinition interface within both the API golden file and the model definition. The type is modified to omit 'enableDateRange' and 'enableTwoMonthDateRange' from DatepickerInputConfig. No review comments were provided, so there is no additional feedback to address.
Member
Author
|
Keeping as a draft, pipeline failure is expected for now and once we open the breaking change window we can drop the check-commit-messages job and then get this one in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replica of #1260, since that PR caused the accidental v50 release and has been reverted.
enableDateRangeandenableTwoMonthDateRangehave no effect when passed indatepickerConfigwith filtered-search criterion.BREAKING CHANGE:
CriterionDefinition.datepickerConfigtype narrowedThe type of
datepickerConfiginCriterionDefinition(filtered-search) changed fromDatepickerInputConfigtoOmit<DatepickerInputConfig, 'enableDateRange' | 'enableTwoMonthDateRange'>.The properties
enableDateRangeandenableTwoMonthDateRangeare no longer accepted indatepickerConfigwhen used with filtered-search criteria, as they had no effect in that context.Migration: Remove any
enableDateRangeandenableTwoMonthDateRangeproperties from yourdatepickerConfigobjects passed toCriterionDefinition.Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: