fix(date-range-filter): add space key support for preset list items#2103
Draft
akashsonune wants to merge 1 commit into
Draft
fix(date-range-filter): add space key support for preset list items#2103akashsonune wants to merge 1 commit into
akashsonune wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds space keydown handling to the date range filter preset list items to prevent default behavior and select the item. The reviewer requested adding a corresponding unit test to verify this behavior, as required by the contribution guidelines.
| [cdkOption]="item.label" | ||
| (click)="selectPresetItem($event, item)" | ||
| (keydown.enter)="selectPresetItem($event, item)" | ||
| (keydown.space)="$event.preventDefault(); selectPresetItem($event, item)" |
Contributor
There was a problem hiding this comment.
According to the repository's contribution guidelines, pull requests that introduce functional changes or bug fixes must include corresponding unit tests. Please add a unit test to verify that pressing the Space key on a preset list item triggers the selection and prevents the default scroll behavior.
References
- PRs that introduce functional changes (new features, bug fixes, refactors affecting behavior) must include corresponding unit tests. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: