fix(chat-messages): adjust scroll height when resizing#2104
Open
robertwilde wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
robertwilde
force-pushed
the
fix/ai/scrollbar
branch
4 times, most recently
from
15eced3 to
8a8335a
Compare
robertwilde
force-pushed
the
fix/ai/scrollbar
branch
from
8a8335a to
f7d8688
Compare
robertwilde
changed the title
|
|
||
| this.resizeObserver = new ResizeObserver(() => { | ||
| this.debouncedScrollToBottom(); | ||
| const element = container.nativeElement; |
Member
There was a problem hiding this comment.
I don't think we should be doing this just to make our e2e pipeline happy unless its real valid use case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the flaky behaviour of the chat-container e2e test introduced with the layout changes in 364fe8e by minding the scroll height when resizing the container. No change to the test necessary. My assumption is the faulty behaviour was always there, but it was never noticed because before the UX updates I made, the content of the chat container never exceeded its length, so in the test it never had to scroll.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: