Skip to content

fix(summary-row): don't show checkbox with summary row#656

Open
chintankavathia wants to merge 1 commit into
siemens:mainfrom
chintankavathia:fix/summary-row/checkbox
Open

fix(summary-row): don't show checkbox with summary row#656
chintankavathia wants to merge 1 commit into
siemens:mainfrom
chintankavathia:fix/summary-row/checkbox

Conversation

@chintankavathia
Copy link
Copy Markdown
Member

checkboxes are only mean't for rows selection and showing it on summary row make no sense.

currently when enabling selectionType with checkbox all rows along with summary row as well shows checkbox.
showing checkbox on summary row doesn't make any sense.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the DataTableSummaryRowComponent to ensure that checkboxes are disabled within the summary row by explicitly setting the checkboxable property to false for all internal columns. I have no feedback to provide.

@chintankavathia chintankavathia marked this pull request as ready for review March 27, 2026 07:10
@chintankavathia chintankavathia requested a review from a team as a code owner March 27, 2026 07:10
@spike-rabbit
Copy link
Copy Markdown
Member

@fh1ch I think the change is good, but I would consider this as breaking. Although I cannot imagine how the CB should have been used before. WDYT?

@chintankavathia Is it even possible for a consumer to get the value of that checkbox in the summary row?

@chintankavathia
Copy link
Copy Markdown
Member Author

@fh1ch I think the change is good, but I would consider this as breaking. Although I cannot imagine how the CB should have been used before. WDYT?

@chintankavathia Is it even possible for a consumer to get the value of that checkbox in the summary row?

No it doesn't emit anything so its just dumb checkbox doing nothing.

@fh1ch fh1ch requested a review from Copilot May 24, 2026 14:05
@fh1ch fh1ch added the bug Something isn't working label May 24, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue in the summary row rendering so that row-selection checkboxes are not shown for the summary row (where selection is not meaningful), aligning summary-row behavior with the intended purpose of checkbox selection.

Changes:

  • Force summary-row internal columns to be non-checkboxable so checkbox inputs are not rendered in summary cells.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

checkboxes are only mean't for rows selection and showing it on summary row make no sense.
@chintankavathia chintankavathia force-pushed the fix/summary-row/checkbox branch from 090c25c to 2731800 Compare May 25, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants