fix(summary-row): don't show checkbox with summary row#656
fix(summary-row): don't show checkbox with summary row#656chintankavathia wants to merge 1 commit into
Conversation
|
@fh1ch I think the change is good, but I would consider this as breaking. Although I cannot imagine how the CB should have been used before. WDYT? @chintankavathia Is it even possible for a consumer to get the value of that checkbox in the summary row? |
No it doesn't emit anything so its just dumb checkbox doing nothing. |
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue in the summary row rendering so that row-selection checkboxes are not shown for the summary row (where selection is not meaningful), aligning summary-row behavior with the intended purpose of checkbox selection.
Changes:
- Force summary-row internal columns to be non-checkboxable so checkbox inputs are not rendered in summary cells.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
checkboxes are only mean't for rows selection and showing it on summary row make no sense.
090c25c to
2731800
Compare
checkboxes are only mean't for rows selection and showing it on summary row make no sense.
currently when enabling
selectionTypewithcheckboxall rows along with summary row as well shows checkbox.showing checkbox on summary row doesn't make any sense.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: