Add CI steps and bump node version#43
Merged
peternandersson merged 17 commits intomainfrom Mar 25, 2026
Merged
Conversation
peternandersson
commented
Mar 24, 2026
| peerDependencies: | ||
| react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 | ||
| react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 | ||
| peerDependenciesMeta: |
Contributor
Author
There was a problem hiding this comment.
I missed this change in a previous PR. CI correctly caught it.
peternandersson
changed the title
abeljohn
reviewed
Mar 24, 2026
| run: corepack enable | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6 |
Contributor
There was a problem hiding this comment.
I believe node_modules caching is built into this action. Can we leverage that instead of trying to handle the caching ourselves?
Contributor
Author
There was a problem hiding this comment.
oh good find. I'll push & play around with it
abeljohn
reviewed
Mar 25, 2026
| cache: 'yarn' | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install ${{ inputs.immutable-install == 'true' && '--immutable' || '' }} |
Contributor
There was a problem hiding this comment.
yarn install is immutable by default in CI. I don't mind adding the explicit flag, but I don't think there's any case where we don't want the install to be immutable in CI
Contributor
Author
There was a problem hiding this comment.
That's surprising. Does yarn throw a status code of 1 when yarn install updates the lock file?
abeljohn
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
Fixes a couple of exposed issues: