store: merge adjacent preads in BucketStorageBackend::BatchLoad#2
Open
pingzhuu wants to merge 1 commit into
Open
store: merge adjacent preads in BucketStorageBackend::BatchLoad#2pingzhuu wants to merge 1 commit into
pingzhuu wants to merge 1 commit into
Conversation
Sort keys by file offset within each bucket, then merge groups of keys whose data ranges are within 256KiB of each other into a single pread call. This reduces syscall count and per-call gap overhead by ~50% (measured on 8-disk NVMe cluster with 64K-token prompts). Also adds VLOG(1) diagnostic logging in BatchLoad and batch_get_into for debugging SSD read patterns. Set CROSSING_LOAD_CHUNK_TOKENS=131072 in prefill template to batch the entire prompt into a single store RPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort keys by file offset within each bucket, then merge groups of keys whose data ranges are within 256KiB of each other into a single pread call. This reduces syscall count and per-call gap overhead by ~50% (measured on 8-disk NVMe cluster with 64K-token prompts).
Also adds VLOG(1) diagnostic logging in BatchLoad and batch_get_into for debugging SSD read patterns.
Set CROSSING_LOAD_CHUNK_TOKENS=131072 in prefill template to batch the entire prompt into a single store RPC.
Description
Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
# Example: bash scripts/run_ci_test.shTest results:
Checklist
./scripts/code_format.shpre-commit run --all-filesand all hooks passAI Assistance Disclosure