TT-7149 each block is a paragraph - not each verse#234
Merged
sarahentzel merged 3 commits intodevelopfrom Apr 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts local Paratext USX syncing so that paragraph boundaries are driven by transcription “blocks” (newlines / explicit markers) rather than forcing each verse into its own paragraph, aligning exported USX structure with intended paragraphing.
Changes:
- Updates USX DOM manipulation to support inserting inline verses within an existing paragraph and to split transcript newlines into continuation
<para style="p">blocks. - Updates
postPasslogic to decide when a verse should start a new paragraph based on transcription layout and to avoid over-deleting surrounding verses when re-syncing. - Modernizes
IntegrationPanelTextField customization to use MUIslotPropsfor Select/Menu styling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/Integration.tsx | Switches MUI TextField select/menu styling from SelectProps/InputProps to slotProps. |
| src/renderer/src/business/localParatext/usxNodeChange.ts | Adds helpers for paragraph container detection + continuation paragraph insertion; updates verse insertion/replacement behavior. |
| src/renderer/src/business/localParatext/usxNodeChange.test.ts | Updates expectations for findNodeAfterVerse and adds coverage for new insertion/continuation behaviors. |
| src/renderer/src/business/localParatext/postPass.ts | Implements “paragraph per block” logic and safer cleanup/reinsert behavior for multi-verse transcriptions. |
| src/renderer/src/business/localParatext/postPass.test.ts | Adds regression tests around re-syncing ranges and keeping multiple verses in a single paragraph. |
| src/renderer/src/business/localParatext/localSync.ts | Preserves transcription newlines instead of flattening them, enabling paragraph-aware sync. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.