Added AVX512BW support - #475
Open
Marabii wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
I added AVX512BW support, a new implementation next to the others (avx2, ...)
It is automatically selected in runtime as the fastest solution when available just like before.
flatten_bitsuses AVX-512VBMI2'svpcompressbwhen available, with ascalar fallback when it isn't.
I had to bump up
SIMDJSON_PADDINGfrom 32 to 64 to match the__m512iwidth.MSRV bumped to 1.89 (required by the AVX-512 intrinsics), CI toolchains and README updated accordingly.
Benchmarked against AVX2 on a 550MB generated JSON file: ~5% faster on
to_tapeand roughly on par for fullto_value, since that path is dominated by hashmap/allocation costs rather than stage-1 parsingFull test suite ran perfectly.
Please let me know if there are any modifications needed before it can be merged.
Thanks!